[Bugfix:TAGrading] Fix Peer Component Version Conflict#13000
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13000 +/- ##
============================================
- Coverage 21.41% 21.41% -0.01%
Complexity 10002 10002
============================================
Files 277 277
Lines 37418 37419 +1
Branches 512 513 +1
============================================
Hits 8013 8013
Misses 28904 28904
- Partials 501 502 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mattLif
changed the title
dagemcn
approved these changes
Jul 3, 2026
dagemcn
left a comment
dagemcn
left a comment
Member
There was a problem hiding this comment.
I was able to observe the incorrect behavior on main, after checking out the branch and testing I was able to confirm that the error no longer appears. Looks good!
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #10772
Since the process of determining graded version did not include the tag used for peer components (just regular components), NaN was being registered as the graded version for peer components. This caused unnecessary version conflict messages.
What is the New Behavior?
Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
On Main:
On Branch:
Automated Testing & Documentation
No automated testing added nor documentation needed.
Other information
Not a breaking change
No migrations
Not a security concern