[Bugfix:Testing] grade_inquiries spec race condition#12999
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12999 +/- ##
=========================================
Coverage 21.41% 21.41%
Complexity 10002 10002
=========================================
Files 277 277
Lines 37418 37418
Branches 512 512
=========================================
Hits 8013 8013
Misses 28904 28904
Partials 501 501
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamjallen
approved these changes
Jul 3, 2026
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The grade inquiries spec was failing when calling the function
verifyWebSocketStatus()because, for some reason, it attempted to edit/redefine a const variable in the testcase-output.js file. Specifically, loading_test_cases_xml_http_requests. I believe this was down to a race condition in the end of this part of the test.What is the New Behavior?
The grade_inquires spec should now pass. The test simply navigates away from the page once it is finished testing 'Test cases revolving around grade inquiries'.
What steps should a reviewer take to reproduce or test the bug or new feature?
On main:
On the branch:
Automated Testing & Documentation
Other information
If there is some other bug with grade_inquiries or the grade_inquiries spec that is causing this, I was unable to determine what it was.