[Feature:TAGrading] Numeric CSV Download#12998
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12998 +/- ##
============================================
- Coverage 21.38% 21.30% -0.09%
- Complexity 9946 10013 +67
============================================
Files 268 275 +7
Lines 37158 37404 +246
Branches 499 505 +6
============================================
+ Hits 7948 7969 +21
- Misses 28715 28934 +219
- Partials 495 501 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mattLif
approved these changes
Jul 3, 2026
mattLif
left a comment
Contributor
There was a problem hiding this comment.
Tested by creating a numeric gradeable. Download CSV button worked as described, and changing the grades caused the expected change in the new csv. As far as tests go, I'm pretty sure all failing ones are flakey except for simple_grading.spec.js, but I could be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12921
What is the New Behavior?
Prior to this PR, on the Numeric/Text gradeable type there was no option to Download a CSV file, despite being able to upload one.
What steps should a reviewer take to reproduce or test the bug or new feature?
Other information
Does this PR include migrations to update existing installations?
N/A