Skip to content

[Bugfix:TAGrading] Add Missing PDFjs Assets#12997

Merged
williamjallen merged 5 commits into
mainfrom
fix-inline-pdf-rendering
Jul 3, 2026
Merged

[Bugfix:TAGrading] Add Missing PDFjs Assets#12997
williamjallen merged 5 commits into
mainfrom
fix-inline-pdf-rendering

Conversation

@mattLif

@mattLif mattLif commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #12764
As of PDFjs 5.x, new assets are required for pdf rendering including wasm, iccs, and standard_fonts. These are not currently copied, resulting in failure of pdf rendering.

What is the New Behavior?

Before change (image on right):
image

After change:
image

What steps should a reviewer take to reproduce or test the bug or new feature?

Verify before behavior (on main):

  1. Upload a file submission using big_image.pdf
  2. As a grader on the grading page, attempt to open the file inline within the file panel
  3. Verify file does not contain image

Verify after behavior (on branch):

  1. run vagrant destroy, vagrant up from scratch to copy npm modules
  2. repeat steps 1 & 2 from before behavior (upload pdf and check as grader)
  3. Verify image appears on pdf

Automated Testing & Documentation

No automated testing added

Other information

Not a breaking change
No migration changes
Not a security concern

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.41%. Comparing base (c33d434) to head (7a005c4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12997   +/-   ##
=========================================
  Coverage     21.41%   21.41%           
  Complexity    10002    10002           
=========================================
  Files           277      277           
  Lines         37418    37418           
  Branches        512      512           
=========================================
  Hits           8013     8013           
  Misses        28904    28904           
  Partials        501      501
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.98% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.37% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)
vue 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dagemcn
dagemcn reviewed Jul 2, 2026
View reviewed changes

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify that the pdf would not render correctly on main and after a vagrant destroy and up the pdf would render correctly. To clarify, in the PR description you say that these packages were not installed prior, but in the code you are just copying them. Are we actually installing new dependencies here? If so, they should be added to the proper documentation. Other than that, solid work on this PR, looks good!

@mattLif

mattLif commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry, I meant copied. The files already exist in node_modules. Updated PR description to correct myself.

dagemcn
dagemcn approved these changes Jul 3, 2026
View reviewed changes

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jul 3, 2026
@williamjallen
williamjallen merged commit 4090f18 into main Jul 3, 2026
26 of 28 checks passed
@williamjallen
williamjallen deleted the fix-inline-pdf-rendering branch July 3, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dagemcn dagemcn dagemcn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TA grading page pdf rendering bug

3 participants

@mattLif @dagemcn @williamjallen