[Bugfix:Testing] rainbow_grading checkbox stability#12976
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12976 +/- ##
=========================================
Coverage 21.41% 21.41%
Complexity 10002 10002
=========================================
Files 277 277
Lines 37418 37418
Branches 512 512
=========================================
Hits 8013 8013
Misses 28904 28904
Partials 501 501
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
roye2
changed the title
roye2
changed the title
roye2
marked this pull request as ready for review
July 2, 2026 13:50
roye2
changed the title
dagemcn
requested changes
Jul 3, 2026
dagemcn
left a comment
dagemcn
left a comment
Member
There was a problem hiding this comment.
I tested the spec on main and was able to observe the instability that you mentioned in the description. After testing on the branch, I was able to run the test multiple times with no failures outside of one regarding the textbox, it would contain text from the previous run through.
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
dagemcn
approved these changes
Jul 3, 2026
dagemcn
left a comment
dagemcn
left a comment
Member
There was a problem hiding this comment.
Looks good, the previous error I observed is fixed. The title and folder change on the spec are also good changes to be more in line with what the spec actually does.
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The rainbow_grading spec was testing the UI by checking and unchecking / interacting with all the elements on the Grades Configuration page. However it did not verify that the boxes were actually checked before moving on to the next one, which led to some flaky / inconsistent behavior.
Additionally, the reset function was not properly clearing the page back to it's original state, meaning subsequent runs of the spec would have different behavior than expected.
I also renamed the spec to grades_configuration.spec.js and moved it to Cypress-Feature since that seemed more appropriate.
What is the New Behavior?
The checkbox interaction and the reset function have been updated to have more stable behavior. I used cy.get with timeouts to ensure that the checkboxes are clicked.
Additionally, I added some small verification in the 'Test Web-Based Rainbow Grades Customization' to make sure that the page is correctly updating when the ui is interacted with.
What steps should a reviewer take to reproduce or test the bug or new feature?
Run rainbow_grading.spec.js locally and ensure it passes.
Also, observe that it passes on the github CI.
Automated Testing & Documentation
Other information
Why isn't this called grades_configuration.spec.js? That is the actual page / functionality that is being tested.