[Bugfix:InstructorUI] Histogram bucket fix#12974
Merged
Merged
Conversation
dagemcn
changed the title
dagemcn
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12974 +/- ##
=========================================
Coverage 21.35% 21.35%
Complexity 9990 9990
=========================================
Files 275 275
Lines 37317 37317
Branches 505 505
=========================================
Hits 7969 7969
Misses 28847 28847
Partials 501 501
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NicholasCiuica
approved these changes
Jul 1, 2026
NicholasCiuica
left a comment
NicholasCiuica
left a comment
Member
There was a problem hiding this comment.
I tested multiple bucket sizes on C++ Hidden Tests and counted the same number of students represented in the histogram. Looks good to me!
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes Issue#12410
What is the New Behavior?
Prior, when using the histogram buckets, entries would commonly be lost due to how the previous increment sorting worked. The way the increments are determined and compared against was updated so that entries will no longer be lost.
For screenshots of the prior behavior, refer to to the linked issue above.
The new behavior is displayed here:
Notice how the total number of entries is 60.
Changing the bucket to include all entries in one column, the number of entries should stay the same.
What steps should a reviewer take to reproduce or test the bug or new feature?
submitty_install_siteC System CallsandC++ Hidden Testswork best as they have manual and autograding results with many sample submissions.Statistics and ChartsAutomated Testing & Documentation
This feature is not tested by E2E testing.