Skip to content

[Bugfix:InstructorUI] Fix markdown in notebook builder#12971

Merged
bmcutler merged 4 commits into
mainfrom
fix-markdown-notebook
Jul 1, 2026
Merged

[Bugfix:InstructorUI] Fix markdown in notebook builder#12971
bmcutler merged 4 commits into
mainfrom
fix-markdown-notebook

Conversation

@dagemcn

@dagemcn dagemcn commented Jun 30, 2026

Copy link
Copy Markdown
Member

Why is this Change Important & Necessary?

Closes Issue #12932

What is the New Behavior?

Prior, the markdown box in the notebook component would appear as follows:
image
It now appears as it should:
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Create a new gradeable
  2. Fill in the title, URL, and ID for the gradeable
  3. Click students will submit one or more files by direct upload to the Submitty website
  4. Click that some of this assignment will be manually graded
  5. Click no for the rest of the options
  6. Go to the submissions/autograding tab
  7. Click start new under the notebook builder section
  8. Add a markdown component
  9. See new behavior

Automated Testing & Documentation

This feature is not covered by any tests (to my knowledge).

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.35%. Comparing base (d96835d) to head (316249f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12971   +/-   ##
=========================================
  Coverage     21.35%   21.35%           
  Complexity     9990     9990           
=========================================
  Files           275      275           
  Lines         37317    37317           
  Branches        505      505           
=========================================
  Hits           7969     7969           
  Misses        28847    28847           
  Partials        501      501           
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.98% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.41% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roye2
roye2 self-requested a review July 1, 2026 19:53
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Jul 1, 2026

@roye2 roye2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the original bug on main. On the branch, the code looks good. I also tested the functionality and it worked as intended. Approving!

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jul 1, 2026
@bmcutler
bmcutler merged commit 01f8919 into main Jul 1, 2026
50 of 56 checks passed
@bmcutler
bmcutler deleted the fix-markdown-notebook branch July 1, 2026 23:31
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants