Skip to content

[Bugfix:Developer] trust hashicorp for vagrant install#12968

Merged
williamjallen merged 3 commits into
mainfrom
fix-package-cloud-vm
Jun 30, 2026
Merged

[Bugfix:Developer] trust hashicorp for vagrant install#12968
williamjallen merged 3 commits into
mainfrom
fix-package-cloud-vm

Conversation

@roye2

@roye2 roye2 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

the install of vagrant was failing on the prepackage cloud vm runner due to 'Error: Refusing to load formula hashicorp/tap/vagrant from untrusted tap hashicorp/tap'.

What is the New Behavior?

https://developer.hashicorp.com/vagrant/install
vagrant is installed per the hashicorp documentation for the install of vagrant on macos using homebrew.
Additionally, the tap is set to be trusted so the install is always run.

What steps should a reviewer take to reproduce or test the bug or new feature?

Observe the most recent run of the Prepackage Cloud VM Action on this branch.

Automated Testing & Documentation

Other information

pr created to test the github action

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jun 29, 2026
@roye2 roye2 changed the title trust hashicorp for vagrant install [Bugfix:Developer] trust hashicorp for vagrant install Jun 29, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.36%. Comparing base (0b452ab) to head (1310bf0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12968      +/-   ##
============================================
- Coverage     21.38%   21.36%   -0.03%     
- Complexity     9946     9990      +44     
============================================
  Files           268      274       +6     
  Lines         37158    37300     +142     
  Branches        499      499              
============================================
+ Hits           7948     7969      +21     
- Misses        28715    28836     +121     
  Partials        495      495              
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.99% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.41% <ø> (-0.03%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roye2
roye2 marked this pull request as ready for review June 29, 2026 18:00
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jun 29, 2026
@roye2
roye2 requested a review from IDzyre June 29, 2026 18:01
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Jun 29, 2026

@williamjallen williamjallen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Successful run here.

@roye2 In the future, it would be helpful to put the link to your manually scheduled job in a comment so it's clear to reviewers that you've tested it.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 30, 2026
@williamjallen
williamjallen merged commit 33b3e37 into main Jun 30, 2026
59 of 61 checks passed
@williamjallen
williamjallen deleted the fix-package-cloud-vm branch June 30, 2026 04:54
jndlansh pushed a commit to jndlansh/Submitty that referenced this pull request Jul 1, 2026
### Why is this Change Important & Necessary?
the install of vagrant was failing on the prepackage cloud vm runner due
to 'Error: Refusing to load formula hashicorp/tap/vagrant from untrusted
tap hashicorp/tap'.

### What is the New Behavior?
https://developer.hashicorp.com/vagrant/install 
vagrant is installed per the hashicorp documentation for the install of
vagrant on macos using homebrew.
Additionally, the tap is set to be trusted so the install is always run.

### What steps should a reviewer take to reproduce or test the bug or
new feature?
Observe the most recent run of the Prepackage Cloud VM Action on this
branch.

### Automated Testing & Documentation


### Other information
pr created to test the github action
prestoncarman added a commit that referenced this pull request Jul 1, 2026
* main: (78 commits)
  [Bugfix:TAGrading] Auto-open single file (#12625)
  [Feature:InstructorUI] Add sortable columns to manage students (#12957)
  [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827)
  [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941)
  [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884)
  [Bugfix:Developer] trust hashicorp for vagrant install (#12968)
  [Feature:TAGrading] Backend for submission clustering (#12886)
  [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955)
  [Bugfix:Submission] Warning Banners Accessibility Fix (#12956)
  [Bugfix:System] Preserve signup fields (#12939)
  [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954)
  [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953)
  [Feature:TAGrading] Persistent Auto-Open (#12931)
  [Bugfix:Submission] Dot File Upload (#12924)
  [Refactor:System] Declutter workers (#12815)
  [Bugfix:Developer] save/restore autograding_containers.json (#12952)
  [Bugfix:InstructorUI] Create Course Validation (#12949)
  [Testing:Notifications] Fix grade_inquiries.spec.js (#12950)
  [UI/UX:System] Add fullscreen button vue component (#12936)
  [Bugfix:TAGrading] Student Name Resize (#12946)
  ...

# Conflicts:
#	.pylintrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants