[Bugfix:TAGrading] Edit Rubric Empty Testcase Fields#12963
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12963 +/- ##
============================================
+ Coverage 21.35% 21.41% +0.05%
- Complexity 9990 10002 +12
============================================
Files 275 277 +2
Lines 37317 37424 +107
Branches 505 513 +8
============================================
+ Hits 7969 8013 +44
- Misses 28847 28909 +62
- Partials 501 502 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
requested changes
Jun 29, 2026
JManion32
left a comment
JManion32
left a comment
Contributor
There was a problem hiding this comment.
Please resolve the failing tests. It looks to me like both were caused by this PR.
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
…lues if undefined
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
NicholasCiuica
approved these changes
Jul 3, 2026
NicholasCiuica
left a comment
NicholasCiuica
left a comment
Member
There was a problem hiding this comment.
PR looks good, I tested and the new functionality works well and consistently.
JManion32
approved these changes
Jul 3, 2026
JManion32
left a comment
JManion32
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I observed the bug on main and was unable to replicate it on the feature branch.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12923
This PR fixes the issue of rubric tab of the grading panel, where clicking Edit Rubric before opening a testcase to grade causes the marks on that testcase to display as having empty values in their point and comment fields.
What is the New Behavior?
The fix is to unconditionally fetch fresh data from the server every single time a component is opened. This ensures that the rendering function always has the correct information to populate the mark fields, whether you are in edit mode or not.
empty.mp4
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
No tests added/modified
Other information