[Feature:InstructorUI] Add sortable columns to manage students#12957
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12957 +/- ##
=========================================
Coverage 21.36% 21.36%
Complexity 9990 9990
=========================================
Files 274 274
Lines 37300 37300
Branches 499 499
=========================================
Hits 7969 7969
Misses 28836 28836
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NicholasCiuica
approved these changes
Jun 26, 2026
NicholasCiuica
left a comment
NicholasCiuica
left a comment
Member
There was a problem hiding this comment.
I tested the new sorting in this PR and it works well. Actually I like this sorting better than on other pages that use sorted columns, like the grading detail page, because on that page a reload is triggered after every sorting. I also did a code review and the code looks clean and well-commented. Nice work!
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
…tty#12957) ### Why is this Change Important & Necessary? Closes Submitty#12917 ### What is the New Behavior? Sortable columns have been added to the manage students page <img width="1620" height="656" alt="image" src="https://github.com/user-attachments/assets/604bfa41-5807-4134-8e89-b074c41efd26" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Navigate to the manage students page and test the sorting of the columns 2. Verify that the columns are sorted within the registration section (ie, the 'least' name should be relative to their section still, sorry if this doesn't make any sense.) ### Automated Testing & Documentation I am not sure how this would be tested by cypress e2e but it could be worth doing. ### Other information It is probably not the best idea to put this in a script tag but I am not sure where else it should go. A follow-up PR will adjust this page further: Registration Subsection will be split off into its own sortable category.
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12917
What is the New Behavior?
Sortable columns have been added to the manage students page
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
I am not sure how this would be tested by cypress e2e but it could be worth doing.
Other information
It is probably not the best idea to put this in a script tag but I am not sure where else it should go.
A follow-up PR will adjust this page further: Registration Subsection will be split off into its own sortable category.