[Bugfix:Submission] Warning Banners Accessibility Fix#12956
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12956 +/- ##
=========================================
Coverage 21.39% 21.39%
Complexity 9946 9946
=========================================
Files 268 268
Lines 37157 37157
Branches 499 499
=========================================
Hits 7948 7948
Misses 28714 28714
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
While looking through color.css I actually found a color variable that already does what we want; --btn-text-black (#000000) is the same for all themes. |
NicholasCiuica
approved these changes
Jun 26, 2026
NicholasCiuica
left a comment
NicholasCiuica
left a comment
Member
There was a problem hiding this comment.
I tested the submission warning and error banners and the text is black in all of the light, dark, and black theme modes. Looks good to me!
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
### Why is this Change Important & Necessary? The submission limit warning banners had low contrast when on dark mode due to the white text. The orange one failed the WAVE test because of this. It is important for us to do our best to pass accessibility guidelines. ### What is the New Behavior? The submission limit warning banners now always have black text even on dark mode <img width="1612" height="1031" alt="image" src="https://github.com/user-attachments/assets/dd24a928-b21d-4639-8df5-59603e1e7439" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. As instructor, create a new gradeable for file submission 2. Submit to the gradeable at least 15 times to see the orange submission limit warning banner 3. Attempt to submit >20 files or a very large file to see the other two banners 4. Verify on main and dark mode, the banners have white text 5. Verify on branch and dark mode, the banners have black text (also, on light mode, the text should still be black) ### Automated Testing & Documentation We needed to add a color to colors.css to do this. ### Other information not a breaking change. Thank you to @NicholasCiuica for the idea.
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The submission limit warning banners had low contrast when on dark mode due to the white text.
The orange one failed the WAVE test because of this. It is important for us to do our best to pass accessibility guidelines.
What is the New Behavior?
The submission limit warning banners now always have black text even on dark mode
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
We needed to add a color to colors.css to do this.
Other information
not a breaking change.
Thank you to @NicholasCiuica for the idea.