[Bugfix:InstructorUI] Missing Subsection in the Edit User form#12955
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12955 +/- ##
============================================
- Coverage 21.39% 21.38% -0.01%
Complexity 9946 9946
============================================
Files 268 268
Lines 37157 37158 +1
Branches 499 499
============================================
Hits 7948 7948
- Misses 28714 28715 +1
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mattLif
self-requested a review
June 25, 2026 20:55
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
mattLif
approved these changes
Jun 26, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
Verified subsection field of edit student form is populated after change. The singular line of code is also good. I'm approving.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
…tty#12955) ### Why is this Change Important & Necessary? Partially addresses Submitty#12927 The student's registration subsection was not defined in the User form (was not passed by the controller) so it wasn't rendering in the field when editing the user. This was an issue because the if the instructor didn't notice, they could accidentally un-set a student's subsection. ### What is the New Behavior? The user's registration subsection is now passed to the edit user form. ### Screenshots Before (subsection not populated) <img width="680" height="761" alt="image" src="https://github.com/user-attachments/assets/589c086e-9f07-4e31-9621-707c02198bd5" /> After (subsection populated) <img width="680" height="761" alt="image" src="https://github.com/user-attachments/assets/3db03562-27f7-4f0e-985f-5f21d8a17502" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. reproduce the original behavior - go to manage students as instructor - edit a student with a subsection and observe it not populating 2. go to the branch and reproduce the new behavior - go to the manage students page - edit a student and observe the subsection correctly populates ### Automated Testing & Documentation It is not necessary to add new tests for this change. ### Other information This is not a breaking change.
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Partially addresses #12927
The student's registration subsection was not defined in the User form (was not passed by the controller) so it wasn't rendering in the field when editing the user.
This was an issue because the if the instructor didn't notice, they could accidentally un-set a student's subsection.
What is the New Behavior?
The user's registration subsection is now passed to the edit user form.
Screenshots
Before (subsection not populated)
After (subsection populated)
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
It is not necessary to add new tests for this change.
Other information
This is not a breaking change.