Skip to content

[Bugfix:InstructorUI] Fix Csv Download of Subsections#12954

Merged
bmcutler merged 9 commits into
mainfrom
csv-download-subsections
Jun 26, 2026
Merged

[Bugfix:InstructorUI] Fix Csv Download of Subsections#12954
bmcutler merged 9 commits into
mainfrom
csv-download-subsections

Conversation

@roye2

@roye2 roye2 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Partially addresses #12927
Before, the download csv button would not populate the registration subsections into the csv.
This was an issue since the download csv was not really compatible with the rest of the page or the upload csv feature. (ie, if you changed some subsections then later downloaded the csv, you would not see the changes).

What is the New Behavior?

The instructor can now see the subsection field populated in the CSV.
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. verify the original functionality on main (downloading the csv does not show the user subsections)
  2. Go to the manage students page as instructor
  3. make sure you have subsections set for some students
  4. download the csv and observe that subsections are filled.
  5. edit some data (including subsections) in the csv and re-upload, the students should update accordingly.

Automated Testing & Documentation

I am not sure if the upload CSV is documented by the Cypress e2e tests, will investigate further.

Other information

Not a breaking change.
No security concerns.
I took this opportunity to refactor the download CSV a little bit to make it easier to add / remove CSV header options in the future.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.40%. Comparing base (0be8ced) to head (ec4d83a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12954      +/-   ##
============================================
- Coverage     21.40%   21.40%   -0.01%     
  Complexity     9944     9944              
============================================
  Files           268      268              
  Lines         37124    37126       +2     
  Branches        494      494              
============================================
  Hits           7948     7948              
- Misses        28686    28688       +2     
  Partials        490      490              
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 2.01% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.44% <0.00%> (-0.01%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roye2
roye2 marked this pull request as draft June 25, 2026 14:49
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 25, 2026
@roye2
roye2 marked this pull request as ready for review June 25, 2026 15:09
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jun 25, 2026

@dandrecollins07-ctrl dandrecollins07-ctrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR functionality works as expected, code looks good. Approving.

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jun 25, 2026
@bmcutler
bmcutler merged commit 91e0249 into main Jun 26, 2026
27 checks passed
@bmcutler
bmcutler deleted the csv-download-subsections branch June 26, 2026 04:17
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 26, 2026
jndlansh pushed a commit to jndlansh/Submitty that referenced this pull request Jul 1, 2026
### Why is this Change Important & Necessary?
Partially addresses Submitty#12927 
Before, the download csv button would not populate the registration
subsections into the csv.
This was an issue since the download csv was not really compatible with
the rest of the page or the upload csv feature. (ie, if you changed some
subsections then later downloaded the csv, you would not see the
changes).

### What is the New Behavior?
The instructor can now see the subsection field populated in the CSV. 
<img width="2050" height="1166" alt="image"
src="https://github.com/user-attachments/assets/ea3402f8-17d3-4708-8516-c128351d1bce"
/>

### What steps should a reviewer take to reproduce or test the bug or
new feature?
0. verify the original functionality on main (downloading the csv does
not show the user subsections)
1. Go to the manage students page as instructor
2. make sure you have subsections set for some students
3. download the csv and observe that subsections are filled.
4. edit some data (including subsections) in the csv and re-upload, the
students should update accordingly.

### Automated Testing & Documentation
I am not sure if the upload CSV is documented by the Cypress e2e tests,
will investigate further.

### Other information
Not a breaking change.
No security concerns. 
I took this opportunity to refactor the download CSV a little bit to
make it easier to add / remove CSV header options in the future.
prestoncarman added a commit that referenced this pull request Jul 1, 2026
* main: (78 commits)
  [Bugfix:TAGrading] Auto-open single file (#12625)
  [Feature:InstructorUI] Add sortable columns to manage students (#12957)
  [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827)
  [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941)
  [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884)
  [Bugfix:Developer] trust hashicorp for vagrant install (#12968)
  [Feature:TAGrading] Backend for submission clustering (#12886)
  [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955)
  [Bugfix:Submission] Warning Banners Accessibility Fix (#12956)
  [Bugfix:System] Preserve signup fields (#12939)
  [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954)
  [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953)
  [Feature:TAGrading] Persistent Auto-Open (#12931)
  [Bugfix:Submission] Dot File Upload (#12924)
  [Refactor:System] Declutter workers (#12815)
  [Bugfix:Developer] save/restore autograding_containers.json (#12952)
  [Bugfix:InstructorUI] Create Course Validation (#12949)
  [Testing:Notifications] Fix grade_inquiries.spec.js (#12950)
  [UI/UX:System] Add fullscreen button vue component (#12936)
  [Bugfix:TAGrading] Student Name Resize (#12946)
  ...

# Conflicts:
#	.pylintrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants