[Bugfix:InstructorUI] Fix Csv Download of Subsections#12954
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12954 +/- ##
============================================
- Coverage 21.40% 21.40% -0.01%
Complexity 9944 9944
============================================
Files 268 268
Lines 37124 37126 +2
Branches 494 494
============================================
Hits 7948 7948
- Misses 28686 28688 +2
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
roye2
marked this pull request as draft
June 25, 2026 14:49
roye2
marked this pull request as ready for review
June 25, 2026 15:09
dandrecollins07-ctrl
approved these changes
Jun 25, 2026
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
PR functionality works as expected, code looks good. Approving.
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
### Why is this Change Important & Necessary? Partially addresses Submitty#12927 Before, the download csv button would not populate the registration subsections into the csv. This was an issue since the download csv was not really compatible with the rest of the page or the upload csv feature. (ie, if you changed some subsections then later downloaded the csv, you would not see the changes). ### What is the New Behavior? The instructor can now see the subsection field populated in the CSV. <img width="2050" height="1166" alt="image" src="https://github.com/user-attachments/assets/ea3402f8-17d3-4708-8516-c128351d1bce" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 0. verify the original functionality on main (downloading the csv does not show the user subsections) 1. Go to the manage students page as instructor 2. make sure you have subsections set for some students 3. download the csv and observe that subsections are filled. 4. edit some data (including subsections) in the csv and re-upload, the students should update accordingly. ### Automated Testing & Documentation I am not sure if the upload CSV is documented by the Cypress e2e tests, will investigate further. ### Other information Not a breaking change. No security concerns. I took this opportunity to refactor the download CSV a little bit to make it easier to add / remove CSV header options in the future.
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Partially addresses #12927
Before, the download csv button would not populate the registration subsections into the csv.
This was an issue since the download csv was not really compatible with the rest of the page or the upload csv feature. (ie, if you changed some subsections then later downloaded the csv, you would not see the changes).
What is the New Behavior?
The instructor can now see the subsection field populated in the CSV.

What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
I am not sure if the upload CSV is documented by the Cypress e2e tests, will investigate further.
Other information
Not a breaking change.
No security concerns.
I took this opportunity to refactor the download CSV a little bit to make it easier to add / remove CSV header options in the future.