[Bugfix:Developer] save/restore autograding_containers.json#12952
Merged
Conversation
bmcutler
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12952 +/- ##
=========================================
Coverage 21.40% 21.40%
Complexity 9944 9944
=========================================
Files 268 268
Lines 37124 37124
Branches 494 494
=========================================
Hits 7948 7948
Misses 28686 28686
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
mattLif
approved these changes
Jun 25, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
recreate_sample_courses ran successfully, and all tests pass locally. I'm approving.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
…#12952) ### Why is this Change Important & Necessary? PR Submitty#12926 moved the location of autograding_containers.json from /usr/local/submitty/config to /var/local/submitty/config. The recreate_sample_courses script was missed during this change. ### What is the New Behavior? The configuration file is saved & restored correctly. ### What steps should a reviewer take to reproduce or test the bug or new feature? On a working vagrant development system, run the recreate_sample_courses script: https://submitty.org/developer/development_instructions/index#re-creating-all-sample-course-data The system should still work normally after the script is finished. Co-authored-by: Barb Cutler <Barb Cutler>
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
bmcutler
added a commit
that referenced
this pull request
Jul 7, 2026
### Why is this Change Important & Necessary? PR #12952 used Python path.rename, which unfortunately does not work when the source and destination files are in different partitions. ### What is the New Behavior? We switch to using Pythons shutil package instead. ### What steps should a reviewer take to reproduce or test the bug or new feature? This change is only significant if the /usr and /var directories are located on different partitions. ### Automated Testing & Documentation Not included in automated testing. We could update our vagrant & CI system setups to have more complicated (& realistic) partition setups. But this is not high priority to do at this time. ### Other information none. Co-authored-by: Barb Cutler <Barb Cutler>
parthrajsinghbhati
pushed a commit
to parthrajsinghbhati/Submitty
that referenced
this pull request
Jul 10, 2026
### Why is this Change Important & Necessary? PR Submitty#12952 used Python path.rename, which unfortunately does not work when the source and destination files are in different partitions. ### What is the New Behavior? We switch to using Pythons shutil package instead. ### What steps should a reviewer take to reproduce or test the bug or new feature? This change is only significant if the /usr and /var directories are located on different partitions. ### Automated Testing & Documentation Not included in automated testing. We could update our vagrant & CI system setups to have more complicated (& realistic) partition setups. But this is not high priority to do at this time. ### Other information none. Co-authored-by: Barb Cutler <Barb Cutler>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
PR #12926 moved the location of autograding_containers.json from
/usr/local/submitty/config to /var/local/submitty/config.
The recreate_sample_courses script was missed during this change.
What is the New Behavior?
The configuration file is saved & restored correctly.
What steps should a reviewer take to reproduce or test the bug or new feature?
On a working vagrant development system, run the recreate_sample_courses script:
https://submitty.org/developer/development_instructions/index#re-creating-all-sample-course-data
The system should still work normally after the script is finished.