[Testing:Notifications] Fix grade_inquiries.spec.js#12950
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12950 +/- ##
=========================================
Coverage 21.41% 21.41%
Complexity 9942 9942
=========================================
Files 268 268
Lines 37118 37118
Branches 495 495
=========================================
Hits 7948 7948
Misses 28679 28679
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
### Why is this Change Important & Necessary? grade_inquiries.spec.js was failing because of a websocket verification failure. This PR fixes that. ### What is the New Behavior? Before, a websocket verification within the test was occuring before cypress properly loaded a page. This was because cypress was queueing the page visit, but then executing the verification before the page was loaded. Now, the verification is in a .then block that runs once the page is confirmed to be loaded. ### What steps should a reviewer take to reproduce or test the bug or new feature? Just run grade_inquiries.spec.js via cypress locally. ### Automated Testing & Documentation No tests needed. ### Other information Not a breaking change No migrations No security concerns
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
grade_inquiries.spec.js was failing because of a websocket verification failure. This PR fixes that.
What is the New Behavior?
Before, a websocket verification within the test was occuring before cypress properly loaded a page. This was because cypress was queueing the page visit, but then executing the verification before the page was loaded. Now, the verification is in a .then block that runs once the page is confirmed to be loaded.
What steps should a reviewer take to reproduce or test the bug or new feature?
Just run grade_inquiries.spec.js via cypress locally.
Automated Testing & Documentation
No tests needed.
Other information
Not a breaking change
No migrations
No security concerns