[Bugfix:TAGrading] Student Name Resize#12946
Merged
Merged
Conversation
This conditional stops student name resizing if the gradeable doesn't have the silent regrade button (meaning it doesn't have manual grading). This conditional doesn't make any sense and should be removed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12946 +/- ##
=========================================
Coverage 21.41% 21.41%
Complexity 9942 9942
=========================================
Files 268 268
Lines 37118 37116 -2
Branches 495 494 -1
=========================================
Hits 7948 7948
+ Misses 28679 28678 -1
+ Partials 491 490 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dandrecollins07-ctrl
approved these changes
Jun 24, 2026
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
Issue appears to be fixed on the PR's branch. Code looks good, approving.
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
### Why is this Change Important & Necessary? While on the grading page, the student's name in the top-left corner resizes dynamically and disappears when it overlaps with the buttons in the top panel. However, this resizing is prevented if the gradeable has the Silent Regrade button. This is unwanted and unnecessary behavior, and this PR removes it. ### What is the New Behavior? The Silent Regrade button now has no effect on how the student's name is displayed on the grading page. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. On main, create a new gradeable with student submissions that has Silent Regrade disabled (the easiest way I have found to do this is to keep manual grading disabled). 2. See that the student's name in the top-left is not sized properly. This is clear when the white line to the right of the student's name does not span the top panel, because that element's height was not dynamically set. 3. Notice also that when you reduce the width of your window, the student's name does not disappear, even after the student's name starts overlapping with the buttons. Issues described in 2 and 3 respectively: <img width="181" height="74" alt="Screenshot 2026-06-23 163658" src="https://github.com/user-attachments/assets/e7eeb608-b704-44bd-9a98-7928c7803341" /> <img width="214" height="77" alt="Screenshot 2026-06-23 164250" src="https://github.com/user-attachments/assets/bcda2932-befd-4adc-91b1-d73ce1375fa9" /> 4. Now go to this PR and repeat steps 2 and 3. Neither issue should be present any longer. <img width="197" height="71" alt="Screenshot 2026-06-23 164946" src="https://github.com/user-attachments/assets/4a517ac2-abf2-41eb-bcd1-e8d9029ee5aa" /> <img width="171" height="74" alt="Screenshot 2026-06-23 164951" src="https://github.com/user-attachments/assets/6dd3467f-d061-44dc-af9b-870678fd34e3" /> ### Automated Testing & Documentation N/A
prestoncarman
added a commit
that referenced
this pull request
Jul 1, 2026
* main: (78 commits) [Bugfix:TAGrading] Auto-open single file (#12625) [Feature:InstructorUI] Add sortable columns to manage students (#12957) [Dependency] Bump php-ds/php-ds from 1.7.0 to 2.0.1 in /site (#12827) [Refactor:TAGrading] Events Infrastructure & StatusBanner (#12941) [Dependency] Bump sqlalchemy from 2.0.48 to 2.0.51 in /.setup/pip (#12884) [Bugfix:Developer] trust hashicorp for vagrant install (#12968) [Feature:TAGrading] Backend for submission clustering (#12886) [Bugfix:InstructorUI] Missing Subsection in the Edit User form (#12955) [Bugfix:Submission] Warning Banners Accessibility Fix (#12956) [Bugfix:System] Preserve signup fields (#12939) [Bugfix:InstructorUI] Fix Csv Download of Subsections (#12954) [Bugfix:InstructorUI] Fix Manage Students Toggle Columns (#12953) [Feature:TAGrading] Persistent Auto-Open (#12931) [Bugfix:Submission] Dot File Upload (#12924) [Refactor:System] Declutter workers (#12815) [Bugfix:Developer] save/restore autograding_containers.json (#12952) [Bugfix:InstructorUI] Create Course Validation (#12949) [Testing:Notifications] Fix grade_inquiries.spec.js (#12950) [UI/UX:System] Add fullscreen button vue component (#12936) [Bugfix:TAGrading] Student Name Resize (#12946) ... # Conflicts: # .pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
While on the grading page, the student's name in the top-left corner resizes dynamically and disappears when it overlaps with the buttons in the top panel. However, this resizing is prevented if the gradeable has the Silent Regrade button. This is unwanted and unnecessary behavior, and this PR removes it.
What is the New Behavior?
The Silent Regrade button now has no effect on how the student's name is displayed on the grading page.
What steps should a reviewer take to reproduce or test the bug or new feature?
Issues described in 2 and 3 respectively:


Automated Testing & Documentation
N/A