Skip to content

[Bugfix:TAGrading] Fix Locked Gradeable Spec#12944

Merged
bmcutler merged 5 commits into
mainfrom
fix-depends-on-gradeable-spec
Jun 23, 2026
Merged

[Bugfix:TAGrading] Fix Locked Gradeable Spec#12944
bmcutler merged 5 commits into
mainfrom
fix-depends-on-gradeable-spec

Conversation

@mattLif

@mattLif mattLif commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

gradeable.spec.js has been consistently failing because of a test within it that checks locked gradeables. This PR fixes that failure.

What is the New Behavior?

gradeable.spec.js should now pass.

What steps should a reviewer take to reproduce or test the bug or new feature?

run submitty_install and run gradeable.spec.js locally and verify it passes.

Automated Testing & Documentation

This PR repairs an automated test and requires no additional testing.

Other information

Not a breaking change
No new migrations
No security risks

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.41%. Comparing base (653ad80) to head (9b0f311).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12944      +/-   ##
============================================
- Coverage     21.50%   21.41%   -0.10%     
- Complexity     9896     9942      +46     
============================================
  Files           268      268              
  Lines         36968    37118     +150     
  Branches        495      495              
============================================
- Hits           7951     7948       -3     
- Misses        28526    28679     +153     
  Partials        491      491              
Flag Coverage Δ
autograder 21.16% <ø> (-0.16%) ⬇️
js 2.01% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.45% <ø> (-0.10%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmcutler
bmcutler merged commit 39bfc3d into main Jun 23, 2026
26 of 27 checks passed
@bmcutler
bmcutler deleted the fix-depends-on-gradeable-spec branch June 23, 2026 18:46
@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Done in Submitty Development Jun 23, 2026
jndlansh pushed a commit to jndlansh/Submitty that referenced this pull request Jul 1, 2026
### Why is this Change Important & Necessary?
gradeable.spec.js has been consistently failing because of a test within
it that checks locked gradeables. This PR fixes that failure.

### What is the New Behavior?
gradeable.spec.js should now pass.

### What steps should a reviewer take to reproduce or test the bug or
new feature?
run submitty_install and run gradeable.spec.js locally and verify it
passes.

### Automated Testing & Documentation
This PR repairs an automated test and requires no additional testing.

### Other information
Not a breaking change
No new migrations
No security risks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants