Skip to content

[Refactor:TAGrading] Migrate RandomizeButtonWarning to Vue#12940

Merged
bmcutler merged 8 commits into
Submitty:mainfrom
jndlansh:ta-grading/RandomizeButtonWarning
Jul 6, 2026
Merged

[Refactor:TAGrading] Migrate RandomizeButtonWarning to Vue#12940
bmcutler merged 8 commits into
Submitty:mainfrom
jndlansh:ta-grading/RandomizeButtonWarning

Conversation

@jndlansh

@jndlansh jndlansh commented Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

In the ongoing migration of Submitty's UI from legacy Twig + jQuery to Vue.js, in this PR we migrate the RandomizeButtonWarning to vue. It is also essentially a popup extension. Super easy and simple migration, will not take much time reviewing

What is the New Behavior?

  • The Behavior should essentially be the same as on main
RandomiseButtonWarning.mp4

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Open any gradeable with Full access Grader (instrcutor)
  2. Ensure the gradeable uses team-based grading
  3. Click on the Randomly Re-Assign Teams to Rotating Sections button
  4. You will get a popup
  5. Click and observe how the component reacts

Automated Testing & Documentation

  • Cypress component tests added.
tests.mp4

Other information

  • Not a Breaking change
  • No migrations needed

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jun 21, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 21, 2026
@codecov

codecov Bot commented Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.33%. Comparing base (af07c0d) to head (2822226).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12940      +/-   ##
============================================
+ Coverage     21.30%   21.33%   +0.02%     
  Complexity    10050    10050              
============================================
  Files           277      278       +1     
  Lines         37609    37623      +14     
  Branches        513      515       +2     
============================================
+ Hits           8014     8028      +14     
  Misses        29093    29093              
  Partials        502      502
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.98% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.25% <ø> (ø)
python_submitty_utils 79.83% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)
vue 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jndlansh jndlansh changed the title {Refactor:TAGrading] Migrate RandomizeButtonWarning to Vue [Refactor:TAGrading] Migrate RandomizeButtonWarning to Vue Jun 21, 2026
@jndlansh
jndlansh marked this pull request as ready for review June 21, 2026 11:38
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jun 21, 2026
JManion32
JManion32 reviewed Jun 23, 2026
View reviewed changes

@JManion32 JManion32 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality and code changes look reasonable, we just need to use the new state management infrastructure.

Your component test video did not load in the description, it just says:
Uploading tests.mp4…. Not a problem by any means though.

@jndlansh

jndlansh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

PR description is now fixed.

I don't think we require the said infrastructure for this PR atleast, any further callbacks without an under lying infrastructure will make this unnecessarily complex

@jndlansh
jndlansh force-pushed the ta-grading/RandomizeButtonWarning branch from a488116 to 8d5aeac Compare June 30, 2026 18:40
@jndlansh

jndlansh commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Hi @JManion32, so now this component has been refactored correctly using #12941 as base infrastructure.
Kindly re-review!

@jndlansh
jndlansh requested a review from JManion32 June 30, 2026 19:11
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Jun 30, 2026
JManion32
JManion32 approved these changes Jul 2, 2026
View reviewed changes

@JManion32 JManion32 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks good to me. The component test covers the component well. This PR follows the pattern we have established for Vue refactors well. Nice work.

EDIT: I looked into the failing Cypress, none of them appear to be related to this PR.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jul 2, 2026
@jndlansh jndlansh mentioned this pull request Jul 2, 2026
Open
@bmcutler
bmcutler merged commit 2c95bca into Submitty:main Jul 6, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JManion32 JManion32 JManion32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jndlansh @JManion32 @bmcutler