[UI/UX:Submission] Collapse File List#12938
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12938 +/- ##
=========================================
Coverage 21.50% 21.50%
Complexity 9896 9896
=========================================
Files 268 268
Lines 36968 36968
Branches 495 495
=========================================
Hits 7951 7951
Misses 28526 28526
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mattLif
approved these changes
Jun 22, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
Tested the dropdown feature and everything works as intended. Code looks good too, so I approve. Couple of thoughts though:
- Do we think the collapse could be useful to appear with a smaller amount for files as well, but only be on by default for amounts over 20?
- Would "Show/Hide" be more intuitive than "Expand/Collapse"?
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Contributor
Author
Changes implemented, thank you. |
mattLif
approved these changes
Jun 23, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
Changes look good, I'm approving
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
### Why is this Change Important & Necessary? Fixes Issue Submitty#10387 Currently, if a student submits more than 20 files, the submitted files section can take up most of the page. This forces students to scroll through a long file list before reaching their autograding results and submission details. ### What is the New Behavior? If a submission contains more than 20 downloadable files, the submitted files section is collapsed by default. Users can expand or collapse the file list using the toggle next to the Submitted Files header. Before: <img width="835" height="472" alt="image" src="https://github.com/user-attachments/assets/25b61817-2f05-46fb-a018-aeb5082b754e" /> After: <img width="1704" height="240" alt="image" src="https://github.com/user-attachments/assets/dda07296-c41f-4644-86b0-8688d3391d58" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? In the main branch: 1. Log in as a student 2. Submit an assignment with 20+ files (you may need to submit a zip, depending on the assignment type) 3. Observe that all submitted files are displayed immediately. In the PR branch: 1. Log in as a student 2. Submit an assignment with 20+ files (you may need to submit a zip, depending on the assignment type) 3. Test the expand files option along with the collapse files option ### Automated Testing & Documentation N/A ### Other information N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes Issue #10387
Currently, if a student submits more than 20 files, the submitted files section can take up most of the page. This forces students to scroll through a long file list before reaching their autograding results and submission details.
What is the New Behavior?
If a submission contains more than 20 downloadable files, the submitted files section is collapsed by default. Users can expand or collapse the file list using the toggle next to the Submitted Files header.
Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
In the main branch:
In the PR branch:
Automated Testing & Documentation
N/A
Other information
N/A