[Bugfix:InstructorUI] Upload CSV parse Registration Subsection#12928
Conversation
roye2
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12928 +/- ##
============================================
- Coverage 21.49% 21.49% -0.01%
- Complexity 9896 9901 +5
============================================
Files 268 268
Lines 36992 36995 +3
Branches 495 495
============================================
Hits 7953 7953
- Misses 28548 28551 +3
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I downloaded the CSV of students from the Manage Students page and then added a Registration Subsection column. I tested adding subsections with alphanumerics, hyphens, underscores, and spaces using the CSV. I also tested that setting a student's subsection to null or blank does not change the student's subsection.
It seems that the subsection column works differently than other columns. For other columns, once a value is set it cannot be changed by the CSV upload. However, for the subsection column, once a value has been set, the student's subsection cannot be made blank, but its value can be set to something else. I think it's best that the subsection column behavior matches the rest of the table for now.
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
@NicholasCiuica The subsection can now not be changed if it was previously set. |
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
cd703a0 to
d541d7d
Compare
f02a7b2 to
a272a4f
Compare
NicholasCiuica
left a comment
NicholasCiuica
left a comment
There was a problem hiding this comment.
I tested this PR again and I approve this change. I was able to give students a subsection if they had none, change a subsection if they had one, or remove their subsection (using blank cell, null/NULL, or whitespace) using the CSV upload feature.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
…tty#12928) ### Why is this Change Important & Necessary? Partially addresses Submitty#12927 The Upload CSV feature had some typos and therefore couldn't parse the Registration Subsection header. Additionally, it was not configured to skip blank cells. ### What is the New Behavior? The Upload CSV feature is now compatible with the 'Registration Subsection' header. Only students with a filled cell will receive a registration subsection. ### Screenshots <img width="1660" height="596" alt="image" src="https://github.com/user-attachments/assets/910a4172-7abd-4628-8bc3-ae4a40302bd4" /> <img width="1920" height="1033" alt="image" src="https://github.com/user-attachments/assets/fdacdc42-4792-463d-a3ea-7f8e1226c4af" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 0. Go to manage students page as instructor 1. Download the existing CSV and add a column with header 'Registration Subsection'. 2. Give some students registration subsections. 3. Upload the file and confirm that the subsections were successfully applied. ### Automated Testing & Documentation There are no tests written for this feature, which could be added in a separate PR. ### Other information This is not a breaking change. --------- Co-authored-by: Nick Ciuica <[email protected]>
3 participants
Why is this Change Important & Necessary?
Partially addresses #12927
The Upload CSV feature had some typos and therefore couldn't parse the Registration Subsection header.
Additionally, it was not configured to skip blank cells.
What is the New Behavior?
The Upload CSV feature is now compatible with the 'Registration Subsection' header.
Only students with a filled cell will receive a registration subsection.
Screenshots
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
There are no tests written for this feature, which could be added in a separate PR.
Other information
This is not a breaking change.