[Bugfix:System] Move autograding_containers.json config#12926
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12926 +/- ##
============================================
+ Coverage 21.45% 21.50% +0.04%
Complexity 9896 9896
============================================
Files 268 268
Lines 36967 36968 +1
Branches 495 495
============================================
+ Hits 7933 7951 +18
+ Misses 28543 28526 -17
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bmcutler
changed the title
added 17 commits
June 19, 2026 12:27
This reverts commit 8cc5586.
This reverts commit 1b3a3e0.
This reverts commit 8ea62c6.
This reverts commit 93f0e25.
This reverts commit 42719b8.
This reverts commit da292d6.
This reverts commit ffbcb76.
This reverts commit 0b4a892.
This reverts commit 019d9b1.
This reverts commit 778b645.
This reverts commit 8a21106.
…[email protected]" This reverts commit 1110a11.
This reverts commit e1811bc.
This reverts commit e830870.
This reverts commit 112fb53.
This reverts commit a75c2b8.
IDzyre
approved these changes
Jun 19, 2026
IDzyre
left a comment
IDzyre
left a comment
Member
There was a problem hiding this comment.
Changes seem reasonable, all code seems like it is similar or same as the old paths, just updated with the data path instead of the install path. I don't see an issue, if the permissions are what you want them to be.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
NicholasCiuica
requested changes
Jun 19, 2026
NicholasCiuica
left a comment
NicholasCiuica
left a comment
Member
There was a problem hiding this comment.
I read through the changes and everything looked good, except for one issue I found.
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
Co-authored-by: Nick Ciuica <[email protected]>
github-project-automation
Bot
moved this from Work in Progress
to Done
in Submitty Development
bmcutler
added a commit
that referenced
this pull request
Jun 25, 2026
### Why is this Change Important & Necessary? PR #12926 moved the location of autograding_containers.json from /usr/local/submitty/config to /var/local/submitty/config. The recreate_sample_courses script was missed during this change. ### What is the New Behavior? The configuration file is saved & restored correctly. ### What steps should a reviewer take to reproduce or test the bug or new feature? On a working vagrant development system, run the recreate_sample_courses script: https://submitty.org/developer/development_instructions/index#re-creating-all-sample-course-data The system should still work normally after the script is finished. Co-authored-by: Barb Cutler <Barb Cutler>
jndlansh
pushed a commit
to jndlansh/Submitty
that referenced
this pull request
Jul 1, 2026
…#12952) ### Why is this Change Important & Necessary? PR Submitty#12926 moved the location of autograding_containers.json from /usr/local/submitty/config to /var/local/submitty/config. The recreate_sample_courses script was missed during this change. ### What is the New Behavior? The configuration file is saved & restored correctly. ### What steps should a reviewer take to reproduce or test the bug or new feature? On a working vagrant development system, run the recreate_sample_courses script: https://submitty.org/developer/development_instructions/index#re-creating-all-sample-course-data The system should still work normally after the script is finished. Co-authored-by: Barb Cutler <Barb Cutler>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
A May 2026 change for Apache and php-fpm security has made the '/usr'
directory read-only for php. Any configuration files that will be
edited through Submitty web pages / GUI need to be moved out of '/usr'.
Currently, this is just the autograding_containers.json file, which is
edited by the docker UI page to add/revise docker containers assigned
to each capability (worker VMs are committed to support capabilities
in the autograding_workers.json file.)
This change is related to issue #12869 and PR #12867
What is the New Behavior?
The docker UI page now allows edits to the containers assigned to each
capability as this autograding_containers.json configuration file has been
moved to /var where it can be edited from the web UI.
What steps should a reviewer take to reproduce or test the bug or new feature?
Visit the DockerUI page from the side bar of the instructor or administrator user.
Automated Testing & Documentation
Hopefully this will fix the Cypress DockerUI failure that has been occuring consistently
since this change was made in Apache.
Other information
Further system edits are likely necessary -- issue #12869 is still unresolved.