[Testing:InstructorUI] Repair Sidebar Spec Failure#12922
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12922 +/- ##
=========================================
Coverage 21.48% 21.48%
Complexity 9842 9842
=========================================
Files 268 268
Lines 36851 36851
Branches 495 495
=========================================
Hits 7919 7919
Misses 28441 28441
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
sidebar.spec.js, part of the UI Cypress test, was inconsistently failing. It seemed to be caused by failure to load the following image in time: http://www.cs.rpi.edu/~cutler/classes/visualization/S18/images/vinca_minor_mirrored.jpg.
What is the New Behavior?
While the test passes consistently locally, it only fails remotely. This change replaces the current image with the google logo (https://www.google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png), which should be more easily accessible than an image on the rpi network. This might not 100% fix the test, just make it less flaky
What steps should a reviewer take to reproduce or test the bug or new feature?
Let the test suite run remotely on github and see if sidebar.spec.js fails.
Automated Testing & Documentation
No testing needed to test feature