[Feature:Notifications] Notification defaults for future courses#12912
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12912 +/- ##
============================================
- Coverage 21.41% 21.35% -0.06%
- Complexity 10002 10027 +25
============================================
Files 277 277
Lines 37418 37519 +101
Branches 512 512
============================================
Hits 8013 8013
- Misses 28904 29005 +101
Partials 501 501
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
changed the title
dagemcn
marked this pull request as ready for review
June 18, 2026 16:53
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
Member
|
@dagemcn please update migration name to be < 7 days old. |
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
Member
|
Only issue I'm seeing on my rereview is that the new sync_notification spec is not passing locally on the last test. It has something to do with student first and last name failing to auto-complete when you select their id in the New Student popup of the Manage Students page. |
jndlansh
reviewed
Jul 1, 2026
jndlansh
reviewed
Jul 1, 2026
jndlansh
reviewed
Jul 1, 2026
jndlansh
requested changes
Jul 1, 2026
github-project-automation
Bot
moved this from In Review
to Work in Progress
in Submitty Development
jndlansh
approved these changes
Jul 1, 2026
jndlansh
left a comment
jndlansh
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing my comments. Great Work!
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes issue #11732
What is the New Behavior?
A new checkbox inside the sync notifications popup has been added that will update a table in the master database with the information of a course whose notification settings we should copy defaults from. There are also UI updates including banners in the notification settings page to show when a course is the default or if another course already is set as the default. Also, the course you are changing notification settings for will no longer appear in the sync notifications menu.
Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
submitty_installSync notification settingsAlso verify the correct banners are displayed in the notification settings page for each course.
Automated Testing & Documentation
Included in this PR.
Other information
This is not a breaking change.
This PR does include a migration.
No known security concerns.