[Bugfix:Testing] Stabilize late submission warning spec#12904
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
dagemcn
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12904 +/- ##
=========================================
Coverage 21.48% 21.48%
Complexity 9842 9842
=========================================
Files 268 268
Lines 36851 36851
Branches 495 495
=========================================
Hits 7919 7919
Misses 28441 28441
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
marked this pull request as ready for review
June 11, 2026 19:11
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
roye2
self-requested a review
June 12, 2026 18:27
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
GarvitKhandelwal31
approved these changes
Jun 15, 2026
GarvitKhandelwal31
left a comment
GarvitKhandelwal31
left a comment
Contributor
There was a problem hiding this comment.
I think the PR correctly identifies the root cause of the failure. The previous logic of hardcoding the due date to 12:00:00 was the real reason of flakiness as also mentioned in the description. The current code change looks good to me and directly fix the root cause.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
It is important to have all cypress tests working and stable so we can know when things have broken.
What is the New Behavior?
Before, if you ran the test after noon, you would experience an off by one error for the team gradeable tests due to how the server rounds late days. I have updated the getDueDateString function to return the due date expressed in terms of the server timezone based on the gradeables due date instead of noon.
What steps should a reviewer take to reproduce or test the bug or new feature?
Run the updated spec locally and in github actions to verify it is passing. Also test around noon/midnight to verify off by one errors are no longer occurring.
Automated Testing & Documentation
N/A
Other information
Not a breaking change.
No migrations included.
No known security concerns.