[Bugfix:Testing] Fix forum spec#12902
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12902 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9861 9861
=========================================
Files 268 268
Lines 36920 36920
Branches 495 495
=========================================
Hits 7990 7990
Misses 28439 28439
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
marked this pull request as ready for review
June 11, 2026 16:18
roye2
approved these changes
Jun 11, 2026
roye2
left a comment
roye2
left a comment
Contributor
There was a problem hiding this comment.
The CI passed locally for me and images now appear to be working in the forums. I am approving since I assume the CI on github will pass again as it did last time checks were ran on this PR.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
williamjallen
left a comment
williamjallen
left a comment
Member
There was a problem hiding this comment.
@dagemcn It isn't immediately clear from your current PR description why the forum tests are currently flaky, or why this change fixes the issue. It's important to document these kinds of things so we can track them in case the tests become flaky again in the future.
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
It is important to have all of our cypress tests working so we can know when features have broken.
What is the New Behavior?
The forum spec should now pass (Cypress-Feature)
What steps should a reviewer take to reproduce or test the bug or new feature?
Run the updated spec locally and in Github actions to verify it is passing.
Automated Testing & Documentation
N/A
Other information
Not a breaking change.
No migrations included.
No security concerns.