[Bugfix:System] Create Account Test Randomization Fix#12898
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12898 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9861 9861
=========================================
Files 268 268
Lines 36920 36920
Branches 495 495
=========================================
Hits 7990 7990
Misses 28439 28439
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NicholasCiuica
changed the title
dandrecollins07-ctrl
approved these changes
Jun 10, 2026
dandrecollins07-ctrl
left a comment
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
Test cases pass, besides the usual common failures. Approving.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Relates to #12455
What is the New Behavior?
The self_create_account Cypress test now randomizes the user id and email used when trying to create a new account during testing, so that the database contents of the testing VM don't affect this test. Originally, this test would break whenever it was run more than once locally or in CI, because the new user that the first attempt at the test made affects how the next attempts run.
What steps should a reviewer take to reproduce or test the bug or new feature?
enable DatabaseAuthentication and create_user_account to test the features added, https://submitty.org/sysadmin/configuration/self_account_creation
run the self_create_account Cypress test locally multiple times.
You will see the "User ID or email already attached to an account" display where it shouldn't be.
Other information
This PR is a portion of the changes I have committed to #12455, but this bugfix is important for working on other database-related PRs.