Skip to content

[Bugfix:TAGrading] TA/Instructor Peer Grading Participation#12895

Merged
bmcutler merged 3 commits into
mainfrom
fix-peer-components-for-ta-instructor
Jun 19, 2026
Merged

[Bugfix:TAGrading] TA/Instructor Peer Grading Participation#12895
bmcutler merged 3 commits into
mainfrom
fix-peer-components-for-ta-instructor

Conversation

@mattLif

@mattLif mattLif commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #10408

What is the New Behavior?

TAs and Instructors can now add to Peer Grading grades even if a student has already added a grade.
image
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. As an instructor:
  • Create a gradable with at least one peer grading component and TA grading access (Assign All grade All in peer matrix)
  1. As a student:
  • Make a submission on the gradeable
  1. As a different student:
  • Leave a peer grade on the previous students submission
  1. As a TA:
  • Attempt to and verify if you can also leave a peer grade on this gradeable (not just edit the student's)
  1. As the instructor:
  • Also attempt to leave a peer grade
  • Check "Peer" tab on grading panel and verify the student, TA, and instructor all left their own peer grades

Automated Testing & Documentation

Added Cypress Test for this change

Other information

This is not a breaking change

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.48%. Comparing base (b9135e9) to head (61071c5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12895      +/-   ##
============================================
- Coverage     21.64%   21.48%   -0.16%     
+ Complexity     9861     9841      -20     
============================================
  Files           268      268              
  Lines         36920    36851      -69     
  Branches        495      495              
============================================
- Hits           7990     7919      -71     
- Misses        28439    28441       +2     
  Partials        491      491              
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.01% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.52% <0.00%> (-0.19%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for the visual bug works as intended and the cypress test passes. However, it is important that after a cypress test completes, it cleans up any changes that it made to the test environment. For this test, it would just involve deleting any added grades for the peer grading component and then deleting the added component.

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 12, 2026
@mattLif
mattLif requested a review from dagemcn June 17, 2026 13:16
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Jun 17, 2026

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 17, 2026
@bmcutler
bmcutler merged commit d15cd83 into main Jun 19, 2026
25 of 27 checks passed
@bmcutler
bmcutler deleted the fix-peer-components-for-ta-instructor branch June 19, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

View of Peer Components grade by TA/instructor user

3 participants