[Bugfix:Testing] Fix profile spec#12894
Merged
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
dagemcn
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12894 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9861 9861
=========================================
Files 268 268
Lines 36920 36920
Branches 495 495
=========================================
Hits 7990 7990
Misses 28439 28439
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
closing in favor or a larger pr with more cypress fixes |
dagemcn
changed the title
dagemcn
marked this pull request as ready for review
June 10, 2026 18:42
roye2
self-requested a review
June 10, 2026 18:47
roye2
approved these changes
Jun 10, 2026
roye2
left a comment
roye2
left a comment
Contributor
There was a problem hiding this comment.
I see that the test now passes on Github. I also got it to pass when running locally. The code changes look good, though I am a little skeptical about force true being used here. For a band-aid fix I think it is ok.
roye2
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
automateprojectmangement
Bot
moved this from In Review
to Seeking Reviewer
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
It is important to have our cypress tests working and up to date so we know when something has broken.
What is the New Behavior?
The profile spec should now pass
What steps should a reviewer take to reproduce or test the bug or new feature?
Run the above specs on main and observe failures, then run on this branch or locally to test new specs.
Automated Testing & Documentation
Locally ran test and ran in github to verify proper execution.
Other information
Not a breaking change.
No migrations included.
No known security issues.
I don't think we should use
force: truein tests but this is a temporary fix until I can get around to stabilizing cypress tests.