[Refactor:System] Enabled Pylint for workers.py#12890
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12890 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9861 9861
=========================================
Files 268 268
Lines 36920 36920
Branches 495 495
=========================================
Hits 7990 7990
Misses 28439 28439
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
approved these changes
Jun 11, 2026
dagemcn
left a comment
dagemcn
left a comment
Member
There was a problem hiding this comment.
I tested pylint locally on workers.py and it passed in github. I also verified vagrant workers generate and vagrant workers up still works.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
dandrecollins07-ctrl
approved these changes
Jun 20, 2026
dandrecollins07-ctrl
left a comment
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
Tested locally, works on my end with no errors. Approving.
williamjallen
approved these changes
Jun 22, 2026
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Working to enable pylint on more files. In the process, workers.py was refactored to have main() split into various functions and some redundant code was removed.
What is the New Behavior?
CI will now check pylint on vagrant-workers/workers.py.
What steps should a reviewer take to reproduce or test the bug or new feature?
Run pylint on vagrant-workers/workers.py.
Automated Testing & Documentation
CI will now be able to test the file.