[Bugfix:TAGrading] TA Peer Grading Access by mattLif · Pull Request #12889 · Submitty/Submitty

mattLif · 2026-06-05T17:03:24Z

Why is this Change Important & Necessary?

Fixes #6367

What is the New Behavior?

TAs now have peer grading access to gradeables that they don't have higher level grading access too. Before, even though they should have had peer grading access, the restrictions on higher level grading access of a gradeable blocked peer grading as well. Now they have peer grading access while still restricting their actual grading access as well.

Although a Gradeable may have non-peer graded components, a TA without grading permissions can only see peer grading components:

What steps should a reviewer take to reproduce or test the bug or new feature?

As an Instructor, create two gradeables (Both with a peer grading component and a non-peer grading component):
a. Make one gradeable Instructor Only grading access
b. Make the other have a minimum access of a Limited Access Grader
Make sure to generate Peer Matrix with All Grade All
As a student, make submissions on both gradeables
As a TA, attempt to grade the Instructor Only gradeable
- Verify that you can reach the rubric screen for the student's submission and only see the peer grading component
Still as a TA, do the same for the other full access gradeable
- Verify that you can reach the rubric screen for the student's submission and see both components

Extra changes made

Hide non peer components on details page from peer only graders
Fix grade button text on details page to say "Grade" for peer graders
Fix rubric to only show Peer Grading total for peer only graders

codecov · 2026-06-05T17:04:33Z

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.51%. Comparing base (653ad80) to head (648429f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12889      +/-   ##
============================================
+ Coverage     21.50%   21.51%   +0.01%     
- Complexity     9896     9905       +9     
============================================
  Files           268      268              
  Lines         36968    36974       +6     
  Branches        495      495              
============================================
+ Hits           7951     7956       +5     
- Misses        28526    28527       +1     
  Partials        491      491

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.01% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.56% <37.50%> (+0.01%)`	⬆️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

roye2

The overall functionality of this PR looks great and I agree with the code changes. I just have a couple requests that I think will make the grading ui and wording more clear for TAs who only have access to peer grading:

I think we should hide the Non Peer Gradiing Manual Total from the TA if they do not have access.

I think we should change the button that says 'Grading Incomplete' and the question circles to only consider the peer grading component, if that's all the TA has access to.

roye2

The functionality and the code look good. I was able to access peer grading as the TA (registered as a student) user even if the grading was for Instructor only. One UI thing I noticed, something looks weird with the stoplights now:

Also, I noticed a discrepancy when grading a peer gradeable as the instructor and ta when the ta is not a student. The Ta and Instructor see different things for 'individual peer grading total' despite the fact that neither of them graded this with the peer components. Is this intended behavior? ** This is a the same as on main. ** I can make an issue about it if necessary but I just thought I'd mention it.

Seen as 'ta' user (not a student)

Seen as 'instructor' user

roye2

With the stoplight fix, code and functionality look good! Just make sure you fix the linting.

This reverts commit 6686eb7.

### Why is this Change Important & Necessary? Fixes #[6367](Submitty#6367) ### What is the New Behavior? TAs now have peer grading access to gradeables that they don't have higher level grading access too. Before, even though they should have had peer grading access, the restrictions on higher level grading access of a gradeable blocked peer grading as well. Now they have peer grading access while still restricting their actual grading access as well. Although a Gradeable may have non-peer graded components, a TA without grading permissions can only see peer grading components: <img width="1892" height="115" alt="image" src="https://github.com/user-attachments/assets/7e0ffa7c-f01e-4c83-a8f1-7fd3fb64d1cf" /> <img width="1909" height="348" alt="image" src="https://github.com/user-attachments/assets/44b38d54-2760-4f08-8c20-122d5e97c6ab" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. As an Instructor, create two gradeables (Both with a peer grading component and a non-peer grading component): a. Make one gradeable Instructor Only grading access b. Make the other have a minimum access of a Limited Access Grader 2. Make sure to generate Peer Matrix with All Grade All 3. As a student, make submissions on both gradeables 4. As a TA, attempt to grade the Instructor Only gradeable - Verify that you can reach the rubric screen for the student's submission and only see the peer grading component 5. Still as a TA, do the same for the other full access gradeable - Verify that you can reach the rubric screen for the student's submission and see both components ### Extra changes made - Hide non peer components on details page from peer only graders - Fix grade button text on details page to say "Grade" for peer graders - Fix rubric to only show Peer Grading total for peer only graders

Grant TAs Peer Grading Access but not Grader Access

c6d25c8

github-project-automation Bot added this to Submitty Development Jun 5, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jun 5, 2026

roye2 self-requested a review June 5, 2026 19:39

automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Jun 5, 2026

roye2 requested changes Jun 5, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development Jun 5, 2026

mattLif added 2 commits June 8, 2026 10:37

Hide Non peer components on details page for peer graders

1a91c30

Fixed Grade Button text on details page for peer graders

6408ba7

GarvitKhandelwal31 self-requested a review June 8, 2026 18:47

automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Jun 8, 2026

Fix Rubric Total Score Box for peer graders

3baaa83

mattLif requested a review from roye2 June 16, 2026 13:19

fix TA access to details and grades

bd4d72d

roye2 reviewed Jun 17, 2026

View reviewed changes

Fix Peer Stoplights

e4b09f6

roye2 self-requested a review June 17, 2026 15:39

roye2 approved these changes Jun 17, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 17, 2026

mattLif added 4 commits June 17, 2026 11:51

fix PHP lint

a2aa5a5

fix autograding-tutorial test failure

6686eb7

Revert "fix autograding-tutorial test failure"

0751ae3

This reverts commit 6686eb7.

Merge branch 'main' into fix-blocked-access-peer-grading

648429f

bmcutler merged commit 695d8b3 into main Jun 23, 2026
25 of 27 checks passed

github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 23, 2026

bmcutler deleted the fix-blocked-access-peer-grading branch June 23, 2026 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bugfix:TAGrading] TA Peer Grading Access#12889

[Bugfix:TAGrading] TA Peer Grading Access#12889
bmcutler merged 10 commits into
mainfrom
fix-blocked-access-peer-grading

mattLif commented Jun 5, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

roye2 left a comment

Uh oh!

roye2 left a comment

Uh oh!

roye2 left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mattLif commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Extra changes made

Uh oh!

codecov Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roye2 left a comment

Choose a reason for hiding this comment

Uh oh!

roye2 left a comment

Choose a reason for hiding this comment

Uh oh!

roye2 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattLif commented Jun 5, 2026 •

edited

Loading

codecov Bot commented Jun 5, 2026 •

edited

Loading

roye2 left a comment •

edited

Loading