[UI/UX:Submission] Submission Limit Warning Banners#12887
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12887 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9861 9861
=========================================
Files 268 268
Lines 36920 36920
Branches 495 495
=========================================
Hits 7990 7990
Misses 28439 28439
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
mattLif
left a comment
mattLif
left a comment
There was a problem hiding this comment.
Code looks good and functionality for each banner works, but I found a bug with duplicate submissions.
On main, if I submit "file1" and "file2" in my first, then I should not be able to submit them again (Submit button is disabled automatically). But if I delete file2 from the submission box, then this is a new submission and the submit button reactivates automatically.
On your branch, I have to refresh to reenable the submit button after deleting a file to make a new submission. It does not reactivate on its own like on main. I think this should be fixed
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
…perly update the submit button
|
I believe I have fixed that bug, good catch! Edit, after CI ran I realized I still need to fix the error with gradeable_spec.js |
mattLif
left a comment
mattLif
left a comment
There was a problem hiding this comment.
Yup, bug's gone, and everything still looks good! I approve.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
5 participants
Why is this Change Important & Necessary?
Closes #12413 .
This change aims to make submission limits (file count, file size, number of penalty-free submissions) and the ui on the submission page more user-friendly so that students can more easily understand how many submissions they have remaining.
What is the New Behavior?
New warning banners have been added to tell the user if they have too many files, files that are too large, or are running out of penalty-free submissions. The penalty free submissions warning appears when a student has 5 or fewer penalty free submissions remaining.
Additionally, if a red banner is showing, the submit button is disabled.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
I will make an issue about testing these banners with Cypress.
Other information
This is not a breaking change.
Some commits are linked from an old, abandoned PR, #12613 .