[Bugfix:TAGrading] Student Custom Marks#12885
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12885 +/- ##
============================================
- Coverage 21.62% 21.61% -0.01%
Complexity 9824 9824
============================================
Files 268 268
Lines 36816 36830 +14
Branches 490 495 +5
============================================
Hits 7960 7960
- Misses 28370 28379 +9
- Partials 486 491 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
roye2
left a comment
roye2
left a comment
There was a problem hiding this comment.
I tested the change and it seems to work as intended. The code makes sense for stopping students specifically from using custom marks when peer grading. I am wondering whether it would be a good idea to also restrict TA's that are also students from using custom marks on the peer grading component. It's possible this would prevent them from using custom marks when grading the TA component, which would not be ideal.
|
Fixed the following bugs I discovered during dev:
|
roye2
left a comment
roye2
left a comment
There was a problem hiding this comment.
Code changes look good. I tested for the bugs you mentioned and none of them appeared. I also tried some other things to find bugs but was unsuccessful in breaking anything. This PR looks good to me!
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
jndlansh
left a comment
jndlansh
left a comment
There was a problem hiding this comment.
I did a code review and the implementation looks good.
4 participants
Why is this Change Important & Necessary?
Fixes #12859
For a gradeable with peer grading, for a component that is peer graded, the peer graders should only be able to choose from the teaching staff prepared point & message common marks. They should not have access to the custom mark feature.
What is the New Behavior?
All peer graders are no longer able to see/choose the "custom mark" option for a peer component of a peer gradeable.
What steps should a reviewer take to reproduce or test the bug or new feature?
As an instructor, create a gradeable that allows for peer grading.
As a student user, submit that gradeable.
As another user (any role), grade that student's submission and compare mark choices.
Automated Testing & Documentation
CI tests still need to be written for Peer Grading.
Peer grading is sufficiently documented, but peer graders not being allowed to make custom marks could be something to add.