Skip to content

[Bugfix:Developer] Fix more CI issues#12857

Merged
williamjallen merged 9 commits into
mainfrom
more-ci
Jun 2, 2026
Merged

[Bugfix:Developer] Fix more CI issues#12857
williamjallen merged 9 commits into
mainfrom
more-ci

Conversation

@IDzyre

@IDzyre IDzyre commented May 21, 2026

Copy link
Copy Markdown
Member

Why is this Change Important & Necessary?

CI is currently failing for an unknown reason, on multiple tests. This PR aims to address the failing tests, and get CI back to passing on main.

Current failing tests:

  • Polls (It was an issue with time zones when creating dates, can't figure out what caused it)
  • DockerUI
  • Late submission warnings
  • Grade Inquiries (passes sometimes, I don't know if it's flaky or bad)

The other failing tests should be addressed, but I don't have the time this week to fix them. Developers should take caution when editing files related to DockerUI tests (as they are failing currently).

#12864 was created to re-write the late submission warnings test, at least the parts that were removed, if not it all.

What steps should a reviewer take to reproduce or test the bug or new feature?

Ensure tests pass locally AND in CI.

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development May 21, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development May 21, 2026
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (9fe4117) to head (49f909f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12857   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9802     9802           
=========================================
  Files           268      268           
  Lines         36723    36723           
  Branches        489      489           
=========================================
  Hits           7960     7960           
  Misses        28278    28278           
  Partials        485      485           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IDzyre
IDzyre marked this pull request as ready for review May 28, 2026 20:53
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development May 28, 2026
@IDzyre IDzyre moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development May 28, 2026
@williamjallen
williamjallen merged commit d8a974a into main Jun 2, 2026
27 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 2, 2026
@williamjallen
williamjallen deleted the more-ci branch June 2, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants