[Bugfix:Developer] Fix Broken CI#12851
Merged
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12851 +/- ##
============================================
- Coverage 21.67% 21.67% -0.01%
- Complexity 9801 9802 +1
============================================
Files 268 268
Lines 36722 36724 +2
Branches 489 489
============================================
Hits 7960 7960
- Misses 28277 28279 +2
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
IDzyre
changed the title
IDzyre
marked this pull request as ready for review
May 20, 2026 05:11
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
IDzyre
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
prestoncarman
added a commit
that referenced
this pull request
May 21, 2026
* main: (50 commits) [Bugfix:Developer] Fix Broken CI (#12851) [Bugfix:System] Restore TCLAPP (#12850) [Bugfix:Submission] Fix non-VCS repo error (#12608) [Feature:Submission] Jupyter warnings outside notebook (#12523) [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826) [Bugfix:Forum] Fix stats header rendering (#12698) [Bugfix:Autograding] Fix negative number tolerance (#12569) [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820) [Bugfix:Autograding] Fix regrade team detection (#12737) [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823) [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824) [Feature:Developer] Remove misc Java utils and TCLAPP (#12819) [Bugfix:TAGrading] Fix 2-panel open-document select (#12577) [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822) [Bugfix:Developer] Fix bump_repo permissions (#12821) [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739) [Bugfix:Forum] Reduce Page Caching (#12339) [Bugfix:System] File lost when running install clean fix (#12158) [Bugfix:Submission] No File Rubric submit all user groups (#12812) [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
CI is currently failing, due to a number of issues. Primarily, for some reason, doctrine is trying (and failing) to generate proxies on "hydration", however they should be pre-generated in CI. I don't know what caused it (assuming an unpinned dependency), as I was able to replicate it ONCE by running
submitty_installandsubmitty_install_siteover and over, but when I destroy'd and re-upped, I was not able to replicate it after.What is the New Behavior?
The doctrine issue is solved by telling the config that if it is debug (which CI is, and production should never be), then assume the proxies are already generated.
This also fixes a notebook builder twig issue.
What steps should a reviewer take to reproduce or test the bug or new feature?
See that CI is now passing for a majority of the issues.