[Feature:InstructorUI] Format notification due dates by AtCloudDiwash · Pull Request #12846 · Submitty/Submitty

AtCloudDiwash · 2026-05-09T12:44:48Z

This PR is the intended to build on #12844

Why is this Change Important & Necessary?

Gradeable release notifications currently store the due date as part of the final notification message. Because of that, the displayed due date does not update when a user changes their selected date/time format preference.

This change stores the due date separately so notification banner dates can be formatted dynamically for the current user.

What is the New Behavior?

Gradeable release notifications now store extra metadata, including the gradeable title and raw due date.

When the notification is displayed, the due date is formatted using the current user’s selected date/time format. If metadata is missing, the old notification text is still used as a fallback.

What steps should a reviewer take to reproduce or test the bug or new feature?

This PR depends on the user date/time format preference feature. Test this after that PR is merged, or test from a branch that includes those changes.

Change the user preferred date format
Navigate to home page and observe the notifications
You'll see the date formats don't change in notification banner

Steps taken to solve

Changed the notification sender so new gradeable release notifications save extra metadata.
Stored the gradeable title and raw due date in that metadata.
Kept the old notification text as a fallback, so old behavior still works if metadata is missing.
Updated the notification model to read the metadata when showing the notification.
Made the notification model format the due date using the current user’s date format preference.
Added a migration to fill in metadata for old gradeable release notifications already in the database.

###Steps to run migration

vagrant ssh
sudo python3 GIT_CHECKOUT/Submitty/migration/run_migrator.py -e course create gradeable_release_notification_metadata.py

…support

…reference

codecov · 2026-05-11T16:20:11Z

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.63%. Comparing base (b9135e9) to head (9200ee5).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12846      +/-   ##
============================================
- Coverage     21.64%   21.63%   -0.02%     
- Complexity     9861     9871      +10     
============================================
  Files           268      268              
  Lines         36920    36938      +18     
  Branches        495      495              
============================================
  Hits           7990     7990              
- Misses        28439    28457      +18     
  Partials        491      491

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.01% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.69% <0.00%> (-0.02%)`	⬇️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AtCloudDiwash · 2026-05-13T17:25:32Z

This PR heavily depends on whether #12844 gets merged, since it is an addition/enhancement to the changes introduced there.

PR #12844 had some issues with how the data was being stored in the database. I felt it would be better practice to separate that concern into its own issue/PR instead of expanding the scope of #12844 further.

So, this PR is intended to build on #12844.

…ting

AtCloudDiwash · 2026-05-19T06:24:11Z

@jndlansh , this is the pr that fixes the issue related to notification panel. Could you please take a look at it.

…ting

dagemcn

Refer to my review on PR#12844 for changes that should overlap with this PR. Also, one of the user date format preference migrations should be removed.

dagemcn · 2026-06-04T14:37:31Z

+    :type database: migrator.db.Database
+    """
+    database.execute("""
+        ALTER TABLE users DROP COLUMN IF EXISTS date_format


We don't want to drop the column and lose data.

@dagemcn completed the requested change with other several overlapping change with pr #12844

…te-formatting

This reverts commit 3ce44c4.

This reverts commit 1b1ca53.

… issue" This reverts commit c0ec161.

…ting

dagemcn

Functionality and code here look good. Tested persistence across log-outs, changing users and different tabs. I'll fully approve once PR#12844 gets merged.

…ting

…rmats

dagemcn

Tested with light and dark mode, persists per account when switching accounts and when clearing cookies. Functionality and code look good. Good work on this.

dagemcn

After talking with our maintainers we would prefer to take a different approach instead of using a migration here. We think it is fine if new notifications are built using the current preference, but we don't need to go back and change all the old ones.

dagemcn · 2026-06-22T20:17:28Z

closing due to inactivity

AtCloudDiwash added 20 commits May 7, 2026 00:37

feat: add migration for user date format preference

3ceeb7a

feat: add setSpecifier method to allow dynamic date format switching

a62d612

feat: add explicit getDateTimeFormat method for per-user date format …

b016761

…support

feat: add updateSubmittyUserDateFormat query method

844d642

feat: add date/time format dropdown to user profile page

3b5adfd

feat: add date_format property with getter and setter for user date p…

8c647f0

…reference

feat: add date/time format dropdown to user profile page

90476c6

feat: add change handler for date format dropdown in user profile

0f49782

add space at line 392 before

4beff29

fix php lint violation

f8d7028

Avoid shared state for per-user date formats

2348b79

add getUTCOffset and add strict check in DateTimeFormat

bd418c1

re-run the migrations to fix db check

ea1d33d

add the dyanmic notification and metadata

f160f1c

add new migrations

d40f112

migration to change the existing notification content

6e1bba5

merges date-format feature with notification enhancement feature

ccfffa4

fix: Restore course schema dump order

e900539

Fix lint for notification metadata date formatting

a59329c

fix stale PHPStan ignore for DateTimeFormat lint

3ce44c4

github-project-automation Bot added this to Submitty Development May 9, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development May 9, 2026

AtCloudDiwash added 2 commits May 13, 2026 13:52

fix: Update model serialization test expectations

c48a99f

Merge branch 'main' into feature/dynamic-notification-due-date-format…

6bc7007

…ting

AtCloudDiwash mentioned this pull request May 19, 2026

[Feature:InstructorUI] Toggle date format #12844

Merged

Merge branch 'main' into feature/dynamic-notification-due-date-format…

87db85a

…ting

dagemcn requested changes Jun 4, 2026

View reviewed changes

github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 4, 2026

AtCloudDiwash added 3 commits June 4, 2026 11:52

Merge branch 'Submitty:main' into feature/dynamic-notification-due-da…

c588c6a

…te-formatting

remove migration down code

782978e

remove unwanted files

03a1230

AtCloudDiwash requested a review from dagemcn June 4, 2026 15:56

automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Jun 4, 2026

AtCloudDiwash and others added 8 commits June 4, 2026 11:58

remove the strict parameter since to be addressed in seperate issue

c0ec161

Revert "fix stale PHPStan ignore for DateTimeFormat lint"

1b1ca53

This reverts commit 3ce44c4.

remove page reload upon date-format change

42a4099

Reapply "fix stale PHPStan ignore for DateTimeFormat lint"

c9a99ee

This reverts commit 1b1ca53.

Revert "remove the strict parameter since to be addressed in seperate…

a08cf63

… issue" This reverts commit c0ec161.

Merge branch 'main' into feature/dynamic-notification-due-date-format…

f52dc2d

…ting

Merge branch 'main' into feature/dynamic-notification-due-date-format…

ac7e803

…ting

Merge branch 'main' into feature/dynamic-notification-due-date-format…

2f61fd0

…ting

dagemcn reviewed Jun 8, 2026

View reviewed changes

AtCloudDiwash added 5 commits June 8, 2026 10:46

fix UI wording on preferred date format dropdown

e9a88ce

add date format preview

e83855e

Merge branch 'main' into feature/dynamic-notification-due-date-format…

1835d59

…ting

remove unnecessary change

fbe05e5

fix: include year in notification banner elapsed dates for MDY/DMY fo…

9200ee5

…rmats

AtCloudDiwash requested a review from dagemcn June 9, 2026 03:08

dagemcn approved these changes Jun 9, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 9, 2026

dagemcn requested changes Jun 9, 2026

View reviewed changes

github-project-automation Bot moved this from Awaiting Maintainer Review to Work in Progress in Submitty Development Jun 9, 2026

dagemcn closed this Jun 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature:InstructorUI] Format notification due dates#12846

[Feature:InstructorUI] Format notification due dates#12846
AtCloudDiwash wants to merge 39 commits into
Submitty:mainfrom
AtCloudDiwash:feature/dynamic-notification-due-date-formatting

AtCloudDiwash commented May 9, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 11, 2026 •

edited

Loading

Uh oh!

AtCloudDiwash commented May 13, 2026

Uh oh!

AtCloudDiwash commented May 19, 2026

Uh oh!

dagemcn left a comment

Uh oh!

dagemcn Jun 4, 2026

Uh oh!

AtCloudDiwash Jun 4, 2026 •

edited

Loading

Uh oh!

dagemcn left a comment

Uh oh!

dagemcn left a comment

Uh oh!

dagemcn left a comment

Uh oh!

dagemcn commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

AtCloudDiwash commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Steps taken to solve

Uh oh!

codecov Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AtCloudDiwash commented May 13, 2026

Uh oh!

AtCloudDiwash commented May 19, 2026

Uh oh!

dagemcn left a comment

Choose a reason for hiding this comment

Uh oh!

dagemcn Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

AtCloudDiwash Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dagemcn left a comment

Choose a reason for hiding this comment

Uh oh!

dagemcn left a comment

Choose a reason for hiding this comment

Uh oh!

dagemcn left a comment

Choose a reason for hiding this comment

Uh oh!

dagemcn commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AtCloudDiwash commented May 9, 2026 •

edited

Loading

codecov Bot commented May 11, 2026 •

edited

Loading

AtCloudDiwash Jun 4, 2026 •

edited

Loading