Thank you @jndlansh for feedback. I will add migration steps and try to resolve the notification panel date issue. Seems like it’s a python script from sbin folder.

Hey @jndlansh, I checked the notification system, and it looks like the notification content is constructed as one full text string, like
Submissions Open: <title> | Due .

The full string is then saved in the notifications table under column content. I have included a screenshot for reference.

A possible quick fix would be to make a database call to get the user’s preferred date format before running the format_timestamp() function in sbin/send_notification.py( currently hardcodes the format as "%Y-%m-%d @ %I:%M %p")

However, this approach is still challenging because if the user changes their preferred date format later, existing notifications will remain in the old format. The change would only apply to notifications created after the preference update.

Could you and the other mentors provide some guidance on the preferred approach here. So that I can take this forward.

Codecov Report

❌ Patch coverage is 32.43243% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.62%. Comparing base (cc61478) to head (a35f48a).

@@            Coverage Diff            @@
##               main   #12844   +/-   ##
=========================================
  Coverage     21.62%   21.62%           
- Complexity     9824     9839   +15     
=========================================
  Files           268      268           
  Lines         36816    36848   +32     
  Branches        490      490           
=========================================
+ Hits           7960     7967    +7     
- Misses        28370    28395   +25     
  Partials        486      486           

Tag me anytime you want to run them again after making changes.

Tag me anytime you want to run them again after making changes.

Thank you @GarvitKhandelwal31. Will keep in mind next. I’ll start working on fixes. If you have any tips on fixing unit tests. Do share.

Tag me anytime you want to run them again after making changes.

Thank you @GarvitKhandelwal31. Will keep in mind next. I’ll start working on fixes. If you have any tips on fixing unit tests. Do share.

I will check the failing results tomorrow.

I checked the CI failures for PHP lint and unit tests. From what I understand, the existing test setup may not cover the feature I added yet. Could someone please help me confirm whether I need to update/add tests for this feature, or suggest the right direction to fix the failures?

I removed few lines from phpstan-baseline.neon because the test were old according to the changes made in the DateTimeFormat.php under site/app/models directory, which resolves the php lint failures. However, php unit CI still fails along with other cypress tests.

@GarvitKhandelwal31 Could you run the tests again? There is still a unit test failing, and I’d appreciate it if you could take a look when you get a chance.

@dagemcn @IDzyre , please review my recent commits. I'll modify the overlapping changes in the PR #12846 too.

Question, is there a reason to not support date and time format? I think the wording of the UI is a little misleading if we don't support both. I think "Change date/time format" should be just "Change date format" and not display " @ 10:30 am" or " @ 10:30 "

Question, is there a reason to not support date and time format? I think the wording of the UI is a little misleading if we don't support both. I think "Change date/time format" should be just "Change date format" and not display " @ 10:30 am" or " @ 10:30 "

@IDzyre , I agree with you on the wording. I should change the UI text to just date format instead of date/time. However, there is one issue. The variables names used in the code can be misleading too. Should I address the variable naming in a seperate issue ?

@IDzyre @dagemcn . Please review the recent commit that addresses confused UI wording.

removed the unnecessary changes in UserTester.php. Kindly review.