[Bugfix:TAGrading] Remove panel selector modal drag#12840
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12840 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9802 9802
=========================================
Files 268 268
Lines 36724 36723 -1
Branches 489 489
=========================================
Hits 7960 7960
+ Misses 28279 28278 -1
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
hey the fix looks good. Please can you update the description of the PR with before and after screenshots. It is always imp to add screenshot in UI fixes. |
|
@GarvitKhandelwal31 , I have included the before after screenshots. I hope they satisfy the requirements of the PR, now. |
|
I have verified the fix works and intended, and makes the quality of the page better. Thanks for the PR. |
|
My pleasure I could contribute. |
|
Can anyone look at the failing checks, some of the failures were very unrelated to what this PR was about. |
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
dagemcn
left a comment
dagemcn
left a comment
There was a problem hiding this comment.
Changes here look good. The bug is fixed, tested on Opera on MacOS
|
Thank you for merging my PR. |
5 participants
Why is this Change Important & Necessary?
Fixes #12839
The Panel Selector modal was draggable with no boundary
constraints. This caused two bugs:
vanish immediately due to click event bubbling
and it would reopen at the same off-screen position
There is no functional reason for the modal to be draggable.
What is the New Behavior?
The Panel Selector modal is no longer draggable. It opens
in its default centered position every time.
##Before - Screenshot
Could be dragged off the center
##After - Screenshot
Panel selector is fixed at the center
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
No automated tests added. The existing Cypress tests for
the panel switcher cover the modal functionality.
Other information
No breaking changes. No migrations required.