[Bugfix:HelpQueue] Fix non-toggling user ID in OHQ#12838
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12838 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9802 9802
=========================================
Files 268 268
Lines 36724 36724
Branches 490 490
=========================================
Hits 7960 7960
Misses 28278 28278
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dandrecollins07-ctrl
approved these changes
Jun 1, 2026
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
Toggle works as expected, icon updates correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a duplicate of PR#12596 with the added cypress tests fixed. Refer to PR#12596 for info and credit to @Akarshkushwaha for the implementation.
Why is this Change Important & Necessary?
Fixes #12595
In the Office Hours Queue interface, the "Show user id" feature was destructive. Clicking the eye icon would overwrite the student's name and remove the toggle button from the DOM, requiring a full page refresh to see student names again. This PR implements a non-destructive toggle that follows standard UI patterns, allowing Instructors to switch back and forth efficiently.
What is the New Behavior?
fa-eye-slash) when the ID is visible.display: inline/display: none) rather than DOM manipulation/removal.What steps should a reviewer take to reproduce or test the bug or new feature?
Before:

After:-

Automated Testing & Documentation
Other information