Skip to content

[Bugfix:HelpQueue] Fix non-toggling user ID in OHQ#12838

Merged
bmcutler merged 17 commits into
mainfrom
toggling-ohq
Jun 1, 2026
Merged

[Bugfix:HelpQueue] Fix non-toggling user ID in OHQ#12838
bmcutler merged 17 commits into
mainfrom
toggling-ohq

Conversation

@dagemcn

@dagemcn dagemcn commented May 5, 2026

Copy link
Copy Markdown
Member

This is a duplicate of PR#12596 with the added cypress tests fixed. Refer to PR#12596 for info and credit to @Akarshkushwaha for the implementation.

Why is this Change Important & Necessary?

Fixes #12595

In the Office Hours Queue interface, the "Show user id" feature was destructive. Clicking the eye icon would overwrite the student's name and remove the toggle button from the DOM, requiring a full page refresh to see student names again. This PR implements a non-destructive toggle that follows standard UI patterns, allowing Instructors to switch back and forth efficiently.

What is the New Behavior?

  • Clicking the "eye" icon reveals the student's User ID while hiding their name.
  • The icon changes to a "slashed eye" (fa-eye-slash) when the ID is visible.
  • Clicking the "slashed eye" icon hides the ID and restores the student's name.
  • This is achieved using CSS visibility toggling (display: inline / display: none) rather than DOM manipulation/removal.

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Navigate to the Office Hours Queue page (viewing as a Instructor).
  2. Click the "Show user id" (eye icon) next to their name.
  3. Verify that the name is replaced by the ID and the icon changes to a slashed eye.
  4. Click the slashed eye icon.
  5. Verify that the student's name is restored and the icon returns to the original state.

Before:
Image

After:-
image

Automated Testing & Documentation

  • This change modifies existing UI templates (CurrentQueue.twig, QueueHistory.twig) and a JavaScript utility in QueueFooter.twig.
  • No new automated tests were added as this is a minor UI logic fix, but manual verification ensures compatibility with existing queue interactions.
  • No update to submitty.org documentation is required as this is a fix to existing behavior.

Other information

  • Breaking Change? No.
  • Migrations needed? No.
  • Security concerns? No.

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (a01d173) to head (e2532b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12838   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9802     9802           
=========================================
  Files           268      268           
  Lines         36724    36724           
  Branches        490      490           
=========================================
  Hits           7960     7960           
  Misses        28278    28278           
  Partials        486      486           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dandrecollins07-ctrl dandrecollins07-ctrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toggle works as expected, icon updates correctly.

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jun 1, 2026
@bmcutler
bmcutler merged commit 95d0a63 into main Jun 1, 2026
@bmcutler
bmcutler deleted the toggling-ohq branch June 1, 2026 16:46
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Inability to toggle user ID back to name in Office Hours Queue

4 participants