Skip to content

[Bugfix:HelpQueue] Always use Abbreviated Names in OH#12820

Merged
bmcutler merged 13 commits into
mainfrom
upstream/#11338
May 1, 2026
Merged

[Bugfix:HelpQueue] Always use Abbreviated Names in OH#12820
bmcutler merged 13 commits into
mainfrom
upstream/#11338

Conversation

@JManion32

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #11338
Users could create their own nickname when joining the office hours queue. This is unnecessary, since the preferred name already lets the user set this preference at a more global level.

What is the New Behavior?

The office hours queue now uses an abbreviated name derived from the students preferred name. This behavior mirrors the discussion forum. There is also a link to the profile page where the student can change their name.

Before:
image

After:
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. On main, go to the office hours queue and observe that you can choose your own nickname.
  2. On this branch, go to the office hours queue and see that the join button now displays: "Join as ". Also observe a working link to the profile page.

Automated Testing & Documentation

This feature is not tested.

Other information

This is not a breaking change.

@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.67%. Comparing base (4cee7f5) to head (745f931).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12820   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
+ Complexity     9808     9806    -2     
=========================================
  Files           268      268           
  Lines         36728    36724    -4     
  Branches        489      489           
=========================================
  Hits           7960     7960           
+ Misses        28283    28279    -4     
  Partials        485      485           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <0.00%> (+<0.01%) ⬆️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkoester47 Rkoester47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes on this PR and can confirm that they work as described. I can see the updated page on the branch, and the link works as intended. The code implementation also looks reasonable. Good work!

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development May 1, 2026
@bmcutler
bmcutler merged commit 064aa2e into main May 1, 2026
17 of 25 checks passed
@bmcutler
bmcutler deleted the upstream/#11338 branch May 1, 2026 04:33
prestoncarman added a commit that referenced this pull request May 21, 2026
* main: (50 commits)
  [Bugfix:Developer] Fix Broken CI (#12851)
  [Bugfix:System] Restore TCLAPP (#12850)
  [Bugfix:Submission] Fix non-VCS repo error (#12608)
  [Feature:Submission] Jupyter warnings outside notebook (#12523)
  [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826)
  [Bugfix:Forum] Fix stats header rendering (#12698)
  [Bugfix:Autograding] Fix negative number tolerance (#12569)
  [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820)
  [Bugfix:Autograding] Fix regrade team detection (#12737)
  [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823)
  [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824)
  [Feature:Developer] Remove misc Java utils and TCLAPP (#12819)
  [Bugfix:TAGrading] Fix 2-panel open-document select (#12577)
  [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822)
  [Bugfix:Developer] Fix bump_repo permissions (#12821)
  [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739)
  [Bugfix:Forum] Reduce Page Caching (#12339)
  [Bugfix:System] File lost when running install clean fix (#12158)
  [Bugfix:Submission] No File Rubric submit all user groups (#12812)
  [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

REMOVE office hour queue nick name -- always use preferred name

4 participants