[Feature:Developer] Add stylelint support for vue files#12807
Merged
Conversation
williamschen23
added
the
Abandoned PR - Needs New Owner
williamschen23
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
williamschen23
marked this pull request as draft
April 22, 2026 00:21
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
automateprojectmangement
Bot
moved this from In Review
to Work in Progress
in Submitty Development
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12807 +/- ##
============================================
+ Coverage 21.56% 21.67% +0.11%
- Complexity 9796 9807 +11
============================================
Files 268 268
Lines 36703 36722 +19
Branches 490 490
============================================
+ Hits 7915 7960 +45
+ Misses 28302 28276 -26
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamjallen
pushed a commit
that referenced
this pull request
Apr 30, 2026
<!-- ** Please remove all comment blocks in the description before submitting this PR. ** --> <!-- NOTE: Please ensure your title and description align with Submitty conventions (see https://submitty.org/developer/getting_started/make_a_pull_request for more details). Each title has a prefix, and a limit of 40 chars. A description template has been provided and must be completed in full. Please also ensure that all CI tests are passing. Pull requests that do not meet these requirements are ineligible for review and may be closed. --> ### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> For the sake of visibility for running `npm run css-stylelint`, there are certain files that are generated by the client/developer that should not be linted. This is not an issue for the CI as it doesnt build the app, it only runs the commands, therefore not generating any developer files ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> Added cypress directory and submitty-vue.css to the ignore file ### What steps should a reviewer take to reproduce or test the bug or new feature? ### Automated Testing & Documentation <!-- Is this feature sufficiently tested by unit tests and end-to-end tests? If this PR does not add/update the necessary automated tests, write a new GitHub issue and link it below. Is this feature sufficiently documented on submitty.org? Link related PRs or new GitHub issue to update documentation. --> ### Other information <!-- Is this a breaking change? Does this PR include migrations to update existing installations? Are there security concerns with this PR? --> TODO: We should probably add a *separate* linter for vue css files #12807
JManion32
removed
the
Abandoned PR - Needs New Owner
JManion32
marked this pull request as ready for review
May 1, 2026 00:18
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
williamjallen
approved these changes
May 1, 2026
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.npmjs.com/package/stylelint-config-standard-vue
https://stackoverflow.com/questions/74960670/how-to-run-stylelint-on-the-style-tag-written-inside-a-vue-file
Why is this Change Important & Necessary?
We should lint vue's css files as well
What is the New Behavior?
lints vue's css files
What steps should a reviewer take to reproduce or test the bug or new feature?
Observe vue's css files are not being linted.
Automated Testing & Documentation
Other information
I really don't want to deal with css right now. If @JManion32 can deal with the css in this PR it would be great. Otherwise, I will get back to it after a few more incoming PRs