Skip to content

[Bugfix:Developer] Add developer CSS ignore files#12806

Merged
williamjallen merged 1 commit into
mainfrom
stylelint-ignore
Apr 30, 2026
Merged

[Bugfix:Developer] Add developer CSS ignore files#12806
williamjallen merged 1 commit into
mainfrom
stylelint-ignore

Conversation

@williamschen23

@williamschen23 williamschen23 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

For the sake of visibility for running npm run css-stylelint, there are certain files that are generated by the client/developer that should not be linted. This is not an issue for the CI as it doesnt build the app, it only runs the commands, therefore not generating any developer files

What is the New Behavior?

Added cypress directory and submitty-vue.css to the ignore file

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

TODO: We should probably add a separate linter for vue css files
#12807

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Apr 22, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Apr 22, 2026
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.51%. Comparing base (224fea2) to head (ee74dbd).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12806      +/-   ##
============================================
- Coverage     21.56%   21.51%   -0.06%     
  Complexity     9796     9796              
============================================
  Files           268      268              
  Lines         36703    37336     +633     
  Branches        490      490              
============================================
+ Hits           7915     8031     +116     
- Misses        28302    28819     +517     
  Partials        486      486              
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.55% <ø> (-0.05%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@williamschen23 williamschen23 changed the title [Bugfix:Developer] Add developer ignore files [Bugfix:Developer] Add developer CSS ignore files Apr 22, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 30, 2026
@williamjallen
williamjallen merged commit 340ecd6 into main Apr 30, 2026
30 checks passed
@williamjallen
williamjallen deleted the stylelint-ignore branch April 30, 2026 18:24
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants