Skip to content

[Bugfix:TAGrading] Allow reopening of student inquiries#12805

Merged
bmcutler merged 7 commits into
Submitty:mainfrom
QuackHonk:allow_reopening_of_student_inquiries
Jun 5, 2026
Merged

[Bugfix:TAGrading] Allow reopening of student inquiries#12805
bmcutler merged 7 commits into
Submitty:mainfrom
QuackHonk:allow_reopening_of_student_inquiries

Conversation

@QuackHonk

@QuackHonk QuackHonk commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #8487

What is the New Behavior?

There didn't seem to be a bug where students can't reopen a grade inquiry if closed. What does seem to be a minor problem is that when reopening a grade inquiry, the student would have to type into the text box before before they could submity a grade inquiry. I'm not too sure how serious an issue this as the student can still reopen grade inquiries, and i can't imagine a case where a student want to reopen with a blank screen, but the change in the code has been made to get rid of the hard-coding

Before

image image image image

After

image image As can be seen, a student can reopen a grade inquiry on blank text. This doesn't create a new blank message, but it does allow the student to reopen the grade inquiry without sending a new message.

Otherwise its the same
image
image
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Find a gradeable or open up a new one as instructor. If its a new gradeable, as a student in a different browser submit something and as instructor grade it.
  2. As instructor set the dates so that currently the gradeable is in inquiry phase (open inquiry date is before now, deadlines are after now)
  3. As student submit an inquiry
  4. as instructor or as student close the inquiry
  5. test that you can reopen the inquiry without sending another message as a student and test the normal case of sending a message as well

This should match the above screenshots: in main, the reopen grade inquiry button is disabled when there is no message but is undisabled when there is a message
for this branch it is not disabled and it should be possible to reopen the inquiry with or without a message

Automated Testing & Documentation

Other information

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Apr 21, 2026
@codecov

codecov Bot commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.62%. Comparing base (c2146f5) to head (ca27d78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12805   +/-   ##
=========================================
  Coverage     21.62%   21.62%           
  Complexity     9819     9819           
=========================================
  Files           268      268           
  Lines         36812    36812           
  Branches        490      490           
=========================================
  Hits           7960     7960           
  Misses        28366    28366           
  Partials        486      486
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.67% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Christian2147 Christian2147 changed the title Allow reopening of student inquiries [Bugfix:TAGrading] Allow reopening of student inquiries Apr 21, 2026
@Christian2147 Christian2147 self-assigned this Apr 22, 2026
@williamschen23

williamschen23 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I was reading the documentation and it says

To reopen the grade inquiry the student must type write a response and click the blue ‘Reopen Grade Inquiry’. The student must write a response.

Maybe this was an intentional design? Otherwise, there should be a change in the documentation PR

@bmcutler

bmcutler commented Apr 25, 2026

Copy link
Copy Markdown
Member

We always want students to type a message when they re-open a closed grade inquiry.
If the inquiry was closed by the instructor/grader because they believe the issue was resolved, we don't want a student to re-open it by just clicking a button. They student should have to explain why they believe the issue is not resolved in order to re-open the issue.

If the current interface is unclear to some students, in that they don't realize that a minimal message is required, then maybe we should update the interface to add some explanatory text. Let's change the "Enter response here" grey text that appears in the box to add, "NOTE: If you wish to re-open this grade inquiry, you must explain why you believe the issue is unresolved."

Christian2147
Christian2147 reviewed Apr 29, 2026
View reviewed changes

@Christian2147 Christian2147 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change and it appears to work flawlessly. However, as mentioned earlier, the behavior is intended but might appear confusing to some student. So explanatory text should be added instead.

@hyeenaa
hyeenaa self-requested a review April 30, 2026 22:22
hyeenaa
hyeenaa reviewed Apr 30, 2026
View reviewed changes

@hyeenaa hyeenaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with christian , apart from that works great.

@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Apr 30, 2026
@github-actions github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label May 15, 2026
@dandrecollins07-ctrl dandrecollins07-ctrl self-assigned this Jun 2, 2026
@dandrecollins07-ctrl dandrecollins07-ctrl mentioned this pull request Jun 2, 2026
Closed
dandrecollins07-ctrl
dandrecollins07-ctrl approved these changes Jun 4, 2026
View reviewed changes

@dandrecollins07-ctrl dandrecollins07-ctrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes test cases. Warning message should probably implement now.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 4, 2026
@github-actions github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 5, 2026
@bmcutler
bmcutler merged commit 249b9c9 into Submitty:main Jun 5, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Christian2147 Christian2147 Christian2147 left review comments
@hyeenaa hyeenaa hyeenaa left review comments
@dandrecollins07-ctrl dandrecollins07-ctrl dandrecollins07-ctrl approved these changes

Assignees

@Christian2147 Christian2147

@dandrecollins07-ctrl dandrecollins07-ctrl

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Students cannot repoen grade inquiry

6 participants

@QuackHonk @williamschen23 @bmcutler @Christian2147 @hyeenaa @dandrecollins07-ctrl