Skip to content

[Bugfix:Submission] Consistent KB Capitalization#12795

Merged
bmcutler merged 1 commit into
mainfrom
capital-kb
Apr 28, 2026
Merged

[Bugfix:Submission] Consistent KB Capitalization#12795
bmcutler merged 1 commit into
mainfrom
capital-kb

Conversation

@Eli-J-Schwartz

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #12794

What is the New Behavior?

Before, the submitted files box listed sizes in "kb":

Screenshot_20260417_141422

After, the submitted files box lists sizes in "KB":

Screenshot_20260417_142223

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Submit any size file for any gradable.
  2. See that the listed size is capitalized.

Automated Testing & Documentation

N/A

Other information

N/A

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.56%. Comparing base (224fea2) to head (575951c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12795   +/-   ##
=========================================
  Coverage     21.56%   21.56%           
  Complexity     9796     9796           
=========================================
  Files           268      268           
  Lines         36703    36703           
  Branches        490      490           
=========================================
  Hits           7915     7915           
  Misses        28302    28302           
  Partials        486      486           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.60% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roye2
roye2 self-requested a review April 17, 2026 18:49
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Apr 17, 2026
roye2

This comment was marked as resolved.

@roye2
roye2 self-requested a review April 17, 2026 19:02

@roye2 roye2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality and code looks good! Small change but I can see why it would be bothersome.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 17, 2026
@dagemcn
dagemcn self-requested a review April 17, 2026 20:06
@automateprojectmangement automateprojectmangement Bot moved this from Awaiting Maintainer Review to In Review in Submitty Development Apr 17, 2026

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 17, 2026
@bmcutler
bmcutler merged commit 1eb2a9d into main Apr 28, 2026
52 of 53 checks passed
@bmcutler
bmcutler deleted the capital-kb branch April 28, 2026 20:54
@williamjallen williamjallen moved this from Awaiting Maintainer Review to Done in Submitty Development Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Inconsistent Capitalization of KB

5 participants