[Testing:Developer] Allow gradeable upload test to be re-run#12785
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12785 +/- ##
=========================================
Coverage 21.56% 21.56%
Complexity 9796 9796
=========================================
Files 268 268
Lines 36703 36703
Branches 490 490
=========================================
Hits 7915 7915
Misses 28302 28302
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
IDzyre
changed the title
IDzyre
marked this pull request as ready for review
April 24, 2026 17:56
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
williamjallen
approved these changes
Apr 30, 2026
williamjallen
approved these changes
Apr 30, 2026
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The gradeable upload tests is currently lot able to be re-run because it creates gradeables, but does not delete them.
What is the New Behavior?
The test sets the state it is looking for Before tests are run, this allows for mid-test cancelling and retrying. It also allows for CI to retry the test and not give false "All changes saved" errors
What steps should a reviewer take to reproduce or test the bug or new feature?
Run the gradeable_upload Cypress test twice. It should run and pass both times.
Other information
We should make all tests that create gradeables do this, or something similar.