Revert "[Bugfix:TAGrading] PDF header overlap fix (#12766)"#12784
Merged
Conversation
This reverts commit 258c709.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12784 +/- ##
=========================================
Coverage 21.56% 21.56%
Complexity 9796 9796
=========================================
Files 268 268
Lines 36703 36703
Branches 490 490
=========================================
Hits 7915 7915
Misses 28302 28302
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bmcutler
added a commit
that referenced
this pull request
Jun 1, 2026
### Why is this Change Important & Necessary? Solves #12763 #12766 changes were reverted by the PR #12784 due to a bug identified in the PR #12779 In PR #12779 in mobile view seeing the PDF is very difficult due to this PDF header overlap. Screen recording of that- https://github.com/user-attachments/assets/f8c0b147-e8b9-494c-b763-ab772d9e2cd0 ### What is the New Behavior? This PR includes all the changes from #12766 while excluding the unnecessary portion identified in #12779. Also it fixes the poor PDF readability in mobile view. https://github.com/user-attachments/assets/78a5cce8-3a93-45c4-8f7a-57428873a8e2 ### What steps should a reviewer take to reproduce or test the bug or new feature? 1) Open TA Grading for a gradeable with PDF submissions. 2) Open a PDF in the Submissions and Results Browser. 3) Verify the top file header remains usable while scrolling the PDF content. 4) Resize browser to narrow/mobile width. 5) Confirm horizontal overflow is not locking the view and PDF remains scrollable/usable. 6) Use page navigation/jump behavior and confirm the expected page scroll target is reached. ### Automated Testing & Documentation No new automated tests were added in this PR (UI/layout and scroll behavior adjustment). ### Other information Breaking change: No. Migrations required: No. Security concerns: None identified. --------- Co-authored-by: Barb Cutler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 258c709.
PR #12766