[Bugfix:Notifications] Fix Broken Course Link#12780
Merged
Merged
Conversation
JManion32
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12780 +/- ##
=========================================
Coverage 21.68% 21.68%
Complexity 9778 9778
=========================================
Files 268 268
Lines 36504 36504
Branches 487 487
=========================================
Hits 7915 7915
Misses 28106 28106
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
approved these changes
Apr 14, 2026
Rkoester47
left a comment
Rkoester47
left a comment
Contributor
There was a problem hiding this comment.
I reproduced the issue on main, and then tried again on this branch and the issue was resolved. Clicking the course title brings me to that course's notification page, as intended.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
A small feature on the home page notifications panel is the course button, which should redirect the user to that course's notification page. Currently, it redirects the user to the origin of the notification just like the rest of the button.
What is the New Behavior?
Clicking the course button now redirects to that course's notification page.
What steps should a reviewer take to reproduce or test the bug or new feature?
On main: Click the course button. Redirect to notification origin.
Feature branch. Click the course button, Redirect to that course's notification page.
Automated Testing & Documentation
#12430 is in progress and will test this feature.
Other information
This is not a breaking change.