[Feature:TAGrading] Limited Access Graders view#12771
Conversation
Implementation is not finished, but upload.pdf is hidden from limited access graders if blind grading is on, or questions are assigned to pdf pages.
Rkoester47
changed the title
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12771 +/- ##
============================================
- Coverage 21.48% 21.47% -0.02%
- Complexity 9842 9854 +12
============================================
Files 268 268
Lines 36851 36872 +21
Branches 495 495
============================================
Hits 7919 7919
- Misses 28441 28462 +21
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
…Submitty/Submitty into limited-access-grader-page-view
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
|
@roye2 or @Rkoester47 please resolve conflicts & then return to 'ready to merge' |
bmcutler
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
…Submitty/Submitty into limited-access-grader-page-view
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
There was a problem hiding this comment.
@bmcutler @Rkoester47
In the bulk_upload_spec.js, the new changes added appear to be failing. I would assume this is a bug with the changes to the spec added in this PR. I would be happy for someone more familiar with cypress to inform me about what is going on. In the meantime, I did fix the merge conflicts and re-reviewed the functionality, which was working as expected as far as I could tell!
github-project-automation
Bot
moved this from In Review
to Work in Progress
in Submitty Development
mattLif
left a comment
mattLif
left a comment
There was a problem hiding this comment.
Tested functionality as Limited Access Grader and TA to verify changes and all worked well. Code looks good too, but there is one failing spec (bulkgradeable) that I think should be addressed. Once that passes should be good.
mattLif
left a comment
mattLif
left a comment
There was a problem hiding this comment.
Code and functionality looks good. Only failing tests are flaky/failing on main.
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
6 participants
Why is this Change Important & Necessary?
Currently, Limited Access Graders (mentors) can access "upload.pdf" in the submissions directory in the Files tab of TA grading. This should be disabled if the mentors do not have reason to see the full, raw uploaded pdf for a gradeable.
What is the New Behavior?
Now, if blind grading for limited Access graders is enabled OR if specific PDF pages have been assigned to any questions, limited access graders can no longer see upload.pdf in the submissions directory of the Files tab when grading.
What steps should a reviewer take to reproduce or test the bug or new feature?
Have two browser windows for different user logins - 'instructor' and 'grader'
As instructor:
As grader:
Automated Testing & Documentation
Other information
This is not a breaking change.