[Feature:Notifications] Sync Notifications Between Courses#12762
Merged
Conversation
added changes to the notificationSettings.twig to display the new buttons. Still need to implement changes in the controller and maybe notification view
started implementing syncSettings in controller
try changing off of available_courses
Wrong function name correction
Attempt to implement popup, should at the very least open a popup
Try fix include error
added indent
added notes for myself, plus example function
Fixed the popup so it displays, plus attempts at fixing other parts of the code
weird commit that doesnt appear locally, trying to resolve it
weird commit that doesnt appear locally, trying to resolve it
Tried changing some of the functions in notification settings as well as the popup twig. Still not functioning as intended
Removed some of the earlier code that turned out non useful
Try to fix backend implementation for the popup to load courses. Currently not working - not loading the user's courses
I changed what I added to the NotificationController to a function, as well as a slight name change in NotificationSettings.twig
Courses now appear in the Sync Notification popup, but requires a great deal of tweaking
Swap from a selection to a checkbox, still many bugs to deal with
Some changes to the formatting, mostly just saving to save progress, does not necessarily work
Remove minor comments
minor changes to comments/naming/spacing
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12762 +/- ##
============================================
- Coverage 21.62% 21.60% -0.02%
- Complexity 9824 9831 +7
============================================
Files 268 268
Lines 36816 36841 +25
Branches 490 490
============================================
Hits 7960 7960
- Misses 28370 28395 +25
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
requested changes
Apr 7, 2026
Fixed the error displaying the popup. No longer includes archived classes. Fixed coloring issue for popup. Cleaned up several large commented code. Start setup to make Sync settings button work.
Many changes to try and implement backend, still needs fixing. Incomplete
Attempt to fix, currently doesnt work
Changed the popup looks again
…github.com/Submitty/Submitty into Sync-Notification-Settings-between-courses
Contributor
|
({{ course.getTerm() }}) — {{ course.getTitle() }} |
Fix the formatting for popup once more, should potentially be the last time
Slight tweak to the final formatting change for popup
JManion32
requested changes
Apr 30, 2026
JManion32
left a comment
JManion32
left a comment
Contributor
There was a problem hiding this comment.
Notes from our demo:
- Use course code and course title (similar to mark seen on home page)
- Use Spring 2026 instead of s26
- Do not include the current course in the popup
- Label text: "To copy the notification settings from Spring 2026 to other courses, select them from the list below."
- Swap the
Sync settingsbutton andClosebutton - Remove notification button grid padding so the header is aligned
- Fix narrow button overlap (use flex-grow and flex-wrap)
- Bottom button should be on the right side
- Add a sentence about what the button does ("To copy the notification settings from Spring 2026 to other courses, click here.")
JManion32
requested changes
Apr 30, 2026
Added a description for the top right sync button, as well as swap the close and sync inside the popup
…github.com/Submitty/Submitty into Sync-Notification-Settings-between-courses
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
dagemcn
removed
the
Abandoned PR - Needs New Owner
…github.com/Submitty/Submitty into Sync-Notification-Settings-between-courses
…github.com/Submitty/Submitty into Sync-Notification-Settings-between-courses
dandrecollins07-ctrl
approved these changes
Jun 5, 2026
dandrecollins07-ctrl
left a comment
dandrecollins07-ctrl
left a comment
Contributor
There was a problem hiding this comment.
Verified both Sync notification settings buttons open the popup, courses can be selected/cleared, and syncing updates the selected courses’ notification settings as expected. Approving.
dagemcn
approved these changes
Jun 8, 2026
github-project-automation
Bot
moved this from Work in Progress
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Partially addresses one item from #11732
Currently there is no way to quickly change the settings of all courses to a specific desired setting. This will help users who may have a significant number of courses to quickly and efficiently apply all their preferred notification settings to whichever courses they wish to all at once.
What is the New Behavior?
This change adds 2 sync notification buttons in the notification's settings section of Submitty. They should be at the top right, and bottom left of the page. This will allow a user to set all selected course's notifications to the current course the user is on. Also included a select all and clear selection button for the popup.
before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
To test these changes, login as any user, enter any course, and navigate to notifications->settings
At this point two Sync notification settings buttons should be present as seen in the earlier images.
Click on either button and it should open a popup that displays all currently enrolled courses
Change the current courses settings and try syncing it to other courses, and vice versa.
Make sure that all notifications change as expected, and that there are no errors when doing so.
Automated Testing & Documentation
Manually tested through a VM across multiple courses
Other information
There are no breaking changes.
There are no migrations.
Syncing should be possible only through courses the user is currently enrolled in.