[Feature:Submission] Create empty submissions for Teams#12761
Conversation
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
feature didn't render correctly when loading or reloading the page. Now, 'Bulk PDF Upload' is the default setting, and if you reload the page on 'Submit All with Placeholder', it will remember your selection and the page will render correctly. Also fixed an issue where the submit button was sometimes disabled.
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12761 +/- ##
============================================
- Coverage 21.66% 21.56% -0.11%
- Complexity 9754 9796 +42
============================================
Files 268 268
Lines 36456 36703 +247
Branches 487 490 +3
============================================
+ Hits 7899 7915 +16
- Misses 28074 28302 +228
- Partials 483 486 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I will also update the documentation in Submitty.org. |
Eli-J-Schwartz
left a comment
Eli-J-Schwartz
left a comment
There was a problem hiding this comment.
I did a functionality review of this PR. Everything worked as intended, and I was able to submit the placeholder for existing teams:
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
hyeenaa
left a comment
hyeenaa
left a comment
There was a problem hiding this comment.
Looks well put together and also functionally works. No issues to my knowledge after testing a few times.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
522318a to
1fa3a15
Compare
bmcutler
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
…sult of install process seeing new folder added
|
Adding a folder and a PDF to the codebase (more_autograding_examples/pdf_exam/submissions/bulk_upload_placeholder.pdf) may have caused the install process to create an extra submission on the sample data students, which is why the assertion in the Cypress System test was failing on these changes. I have updated the test to check for '102 submissons' instead of '101' submissions in the appropriate spot. It was hardcoded before and it is hardcoded now, but eventually we should see if there's a way to make this more flexible. |
Added team documentation on the page for the No File Rubric Grading feature instructors have access to on Bulk Upload type gradeables. Team functionality is being added in PR #12761 in the Submitty site. Submitty/Submitty#12761 Screenshot: <img width="1920" height="923" alt="image" src="https://github.com/user-attachments/assets/c78203f6-d2c2-48e9-934a-dbce94da9902" />
4 participants
Why is this Change Important & Necessary?
#Closes #11144
What is the New Behavior?
Added team functionality to my earlier changes in PR #12576
Now, after making teams on a Team Bulk Upload Gradeable, an instructor can use this feature to have no-file submissions generated for each team. A placeholder pdf will be submitted to enable the use of rubric for grading.
The submissions can be graded using a rubric like any other team submission.
What steps should a reviewer take to reproduce or test the bug or new feature?
Note, please use submitty_install rather than submitty_install_site as a pdf has been added to the non-site codebase.
On a Team Bulk Upload Gradeable:
Automated Testing & Documentation
I have not added any automated testing for this PR.
Other information
More information can be found in PR #12576