[Bugfix:InstructorUI] Fix Instructor Edit Team Add User Menu #12758
Merged
Conversation
Rkoester47
approved these changes
Apr 7, 2026
Rkoester47
left a comment
Rkoester47
left a comment
Contributor
There was a problem hiding this comment.
I tested the functionality of the changes made on this PR, and can confirm the issue was resolved. The dropdown is in front and fully visible when adding team members to a team.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Contributor
Author
Thank you @Rkoester47! |
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
Contributor
Author
|
Thank you for merging this PR! @bmcutler |
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 13, 2026
…y#12758) <!-- ** Please remove all comment blocks in the description before submitting this PR. ** --> <!-- NOTE: Please ensure your title and description align with Submitty conventions (see https://submitty.org/developer/getting_started/make_a_pull_request for more details). Each title has a prefix, and a limit of 40 chars. A description template has been provided and must be completed in full. Please also ensure that all CI tests are passing. Pull requests that do not meet these requirements are ineligible for review and may be closed. --> ### Why is this Change Important & Necessary? Closes Submitty#12755 and fixes Submitty#12769 When instructors edit a team and add more than two members via the admin team form modal, the jQuery UI autocomplete suggestion dropdown was rendering **behind the popup** instead of above it, making it impossible to select students. This is a usability bug that affects the team management workflow. ### What is the New Behavior? The autocomplete suggestion menu now consistently displays **above/inside the modal** for all dynamically added member input fields, matching the behavior of the initial two member inputs. Users can now successfully add 3+ members to a team without the dropdown being obscured. <img width="1913" height="895" alt="Screenshot 2026-04-07 134112" src="https://github.com/user-attachments/assets/62c89702-be68-4119-b55a-b291893aa2da" /> <img width="1919" height="774" alt="Screenshot 2026-04-07 134833" src="https://github.com/user-attachments/assets/70682e8b-6570-4c5d-b269-696bf496ca40" /> ### What steps should a reviewer take to reproduce or test the bug/new feature? 1. Navigate to a team gradeable's grading details page 2. Edit a team 3. Click "Add More Users" to create a 3rd member input field 4. Type a student name/ID in the field to trigger autocomplete 5. **Verify**: The suggestion dropdown appears **inside the modal**, not behind it 6. Select a suggestion and submit to confirm the new member is added ### Automated Testing & Documentation This is a UI/styling fix. Existing form validation tests remain unchanged. Manual testing confirms the correct behavior. ### Other information - Not a breaking change - No database migrations needed - No security concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12755 and fixes #12769
When instructors edit a team and add more than two members via the admin team form modal, the jQuery UI autocomplete suggestion dropdown was rendering behind the popup instead of above it, making it impossible to select students. This is a usability bug that affects the team management workflow.
What is the New Behavior?
The autocomplete suggestion menu now consistently displays above/inside the modal for all dynamically added member input fields, matching the behavior of the initial two member inputs. Users can now successfully add 3+ members to a team without the dropdown being obscured.
What steps should a reviewer take to reproduce or test the bug/new feature?
Automated Testing & Documentation
This is a UI/styling fix. Existing form validation tests remain unchanged. Manual testing confirms the correct behavior.
Other information